From: Tom Lane <tgl@sss.pgh.pa.us>
To: David E. Wheeler <david@justatheory.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Nathan Bossart <nathandbossart@gmail.com>
Cc: pgsql-hackers@postgresql.org, Andrew Dunstan <andrew@dunslane.net>
Cc: Mankirat Singh <mankiratsingh1315@gmail.com>
Subject: Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()
Date: Thu, 30 Oct 2025 09:55:42 -0400
Message-ID: <3019008.1761832542@sss.pgh.pa.us> (raw)
In-Reply-To: <3BCE0A41-562A-4888-B6FE-C5EFCA2E93B0@justatheory.com>
References: <2923669.1761781931@sss.pgh.pa.us>
<A067B3A3-1CB8-44CC-A695-C5D4EDDE847A@justatheory.com>
<2944096.1761792564@sss.pgh.pa.us>
<3BCE0A41-562A-4888-B6FE-C5EFCA2E93B0@justatheory.com>
"David E. Wheeler" <david@justatheory.com> writes:
> Might I suggest, however, that it also run for branches matching /_STABLE$/ even if there is no .abi-hstory-file? The whole point of this exercise was to increase the confidence in ABI stability in stable branches. Running it in such branches would help remind maintainers to add the file.
Trouble is, you then need an arbitrary client-made choice about which
commit to run the ABI check against. If that code does something we
realize we don't want, we're back up against the problem of moving the
buildfarm configuration to fix it. I'd rather the decision be opt-in.
(Also, the only rules I heard proposed for such client-driven choices
involved git tags. I already explained why I don't want that: git
tags are hard to modify and subject to too many other constraints.)
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, david@justatheory.com, bruce@momjian.us, nathandbossart@gmail.com, andrew@dunslane.net, mankiratsingh1315@gmail.com
Subject: Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()
In-Reply-To: <3019008.1761832542@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox