From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Garbled comment in postgresGetForeignJoinPaths
Date: Wed, 16 Aug 2017 14:16:43 -0400
Message-ID: <302.1502907403@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmoY377WU7N-Z6D5iCRWVJWY9G+RzaomD+eOX28dOLEnyeQ@mail.gmail.com>
References: <27897.1502901074@sss.pgh.pa.us>
<CA+TgmoY377WU7N-Z6D5iCRWVJWY9G+RzaomD+eOX28dOLEnyeQ@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Aug 16, 2017 at 12:31 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> --> * reconstruct the row for EvalPlanQual(). Find an alternative local path
>> Should the marked line simply be deleted? If not, what correction is
>> appropriate?
> Hmm, wow. My first thought was that it should just say
> "reconstructing" rather than "reconstruct", but on further reading I
> think you might have the right idea.
The current text of the comment dates to commit 177c56d60, and looking at
that commit makes it pretty clear that the line I'm complaining of
belonged to the previous text; it evidently just missed getting deleted.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com
Subject: Re: Garbled comment in postgresGetForeignJoinPaths
In-Reply-To: <302.1502907403@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox