pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: PostgreSQL Developers <pgsql-hackers@postgresql.org>
Subject: Re: pgbench - allow to store select results into variables
Date: Wed, 04 Jan 2017 16:15:58 -0500
Message-ID: <30247.1483564558@sss.pgh.pa.us> (raw)
In-Reply-To: <alpine.DEB.2.20.1609261324480.11795@lancre>
References: <alpine.DEB.2.20.1607091005330.3412@sto>
	<CAFj8pRAgU0OzGM7Vqpf2KUR0KP2YNhtG54ji06W5StGmwyQKnA@mail.gmail.com>
	<alpine.DEB.2.20.1607091057300.3412@sto>
	<CAFj8pRBGrdiroRyJgCjtOmOrHCQu0L8KDGLU5czD2q+jF8bUxQ@mail.gmail.com>
	<alpine.DEB.2.20.1607091441480.3412@sto>
	<CA+TgmoaFOUVh5E5qbMjV6L6ub1NFML7U+4Cx+8CvLQgRPrO4Ng@mail.gmail.com>
	<32184.1468440143@sss.pgh.pa.us>
	<alpine.DEB.2.20.1607151820160.7291@sto>
	<10663af8-de38-9c4b-1363-33d1c51e8808@lab.ntt.co.jp>
	<alpine.DEB.2.20.1609021943130.9507@lancre>
	<1dd0fb0c-f747-33f6-11f4-9a3c20926d7b@lab.ntt.co.jp>
	<alpine.DEB.2.20.1609062144220.28392@lancre>
	<de93db2a-539e-4044-bca8-47f2afa01ce1@lab.ntt.co.jp>
	<alpine.DEB.2.20.1609130730380.10870@lancre>
	<5d23c2f2-9f3e-6b2c-1496-557c00db5b81@lab.ntt.co.jp>
	<alpine.DEB.2.20.1609141323260.30659@lancre>
	<ff6e25c6-6f8e-e7c7-0860-e09f44dcd530@lab.ntt.co.jp>
	<3bc70111-f847-6c05-9dbe-f56494d01672@lab.ntt.co.jp>
	<alpine.DEB.2.20.1609261324480.11795@lancre>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Fabien COELHO <coelho@cri.ensmp.fr> writes:
> Indeed. Here is the rebased version, which still get through my various 
> tests.

I looked through this again, and I still think that the syntactic design
of the new command is seriously misguided, leading to an ugly and
unmaintainable implementation that may well block further innovation
in pgbench.  I will not commit it in this form.

Possibly you can find some other committer whom you can convince this
is a good design --- but since the patch has gone untouched for two full
commitfest cycles, I rather imagine that whoever else has looked at it
has likewise decided they didn't want to be responsible for it.

Please look at changing \into to be a SQL-command-ending backslash
command as we previously discussed.  I think you will find that the
implementation is a great deal simpler that way and doesn't require
weird hackery on the shared lexer.

(BTW, said hackery is not just weird but broken.  You can't simply
remove comments.  Consider something like "SELECT foo/*as*/bar".
This code reduces that to "SELECT foobar" which is wrong.)

If you won't do that, and you can't find another committer who will
accept responsibility for this patch before the end of the current
commitfest, I think we should mark it Rejected.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (120+ messages)  latest in thread

Message-ID: <30247.1483564558@sss.pgh.pa.us>
Permalink:  ../30247.1483564558@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/30247.1483564558@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, coelho@cri.ensmp.fr, Langote_Amit_f8@lab.ntt.co.jp, robertmhaas@gmail.com, pavel.stehule@gmail.com
  Subject: Re: pgbench - allow to store select results into variables
  In-Reply-To: <30247.1483564558@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox