From: Tom Lane <tgl@sss.pgh.pa.us>
To: John Naylor <jcnaylor@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: docs: outdated reference to recursive expression evaluation
Date: Sat, 08 Dec 2018 11:30:31 -0500
Message-ID: <30253.1544286631@sss.pgh.pa.us> (raw)
In-Reply-To: <CAJVSVGUPH-0q5feP4v9b+Y8K3HGTn3bEd5KV7VbyUj-oFdSLzA@mail.gmail.com>
References: <CAJVSVGUPH-0q5feP4v9b+Y8K3HGTn3bEd5KV7VbyUj-oFdSLzA@mail.gmail.com>
John Naylor <jcnaylor@gmail.com> writes:
> In confg.sgml, in the section about max_stack_depth, there's this sentence:
> "The safety margin is needed because the stack depth is not checked in
> every routine in the server, but only in key potentially-recursive
> routines such as expression evaluation."
> Since the change in expression evaluation in v10, there's probably a
> better example of recursive routines, but I'm not sure what that would
> be.
We could say "expression compilation" and it'd still be valid. Or just
drop the last four words altogether. I don't think we want to expend the
verbiage to be more precise here, since it's only a tangential point.
BTW, while looking at this I noted that copyfuncs.c has a
check_stack_depth call but outfuncs, readfuncs, equalfuncs don't.
Surely that's not good.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, jcnaylor@gmail.com
Subject: Re: docs: outdated reference to recursive expression evaluation
In-Reply-To: <30253.1544286631@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox