pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Noah Misch <noah@leadboat.com>
Cc: Vik Fearing <vik@postgresfriends.org>
Cc: cary huang <hcary328@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Add support for AT LOCAL
Date: Tue, 17 Oct 2023 23:15:14 -0400
Message-ID: <3032037.1697598914@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+hUKG+SYQ+MOXxt-bZhj2HzJXFADVW63UsF6xf504Y_bxx+og@mail.gmail.com>
References: <ZSyYqySa74x_RAH_@paquier.xyz>
	<CA+hUKGLYaVJ7df+Uu=ctUunRcqUsGY55feVQa-1pzz1=PT=z3w@mail.gmail.com>
	<2188264.1697425365@sss.pgh.pa.us>
	<CA+hUKGJSEOVonGsYCiuhZXsBFCxXtjNyHGYvn-w9jykGo2PgqQ@mail.gmail.com>
	<2191749.1697427017@sss.pgh.pa.us>
	<20231016045804.c0@rfd.leadboat.com>
	<20231016055051.3a@rfd.leadboat.com>
	<2208907.1697435663@sss.pgh.pa.us>
	<20231016060510.72@rfd.leadboat.com>
	<2659915.1697521218@sss.pgh.pa.us>
	<ZS4oykeg1ydoTM0W@paquier.xyz>
	<2726901.1697556666@sss.pgh.pa.us>
	<2820407.1697561128@sss.pgh.pa.us>
	<CA+hUKGKdDBrh4PnW6Bw67wUmVHVzJMKH-3rK25NJg9nD9vUndg@mail.gmail.com>
	<2995973.1697583273@sss.pgh.pa.us>
	<CA+hUKG+SYQ+MOXxt-bZhj2HzJXFADVW63UsF6xf504Y_bxx+og@mail.gmail.com>

Thomas Munro <thomas.munro@gmail.com> writes:
> On Wed, Oct 18, 2023 at 11:54 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Should we be testing against xlclang instead?

> I hesitated to suggest it because it's not my animal/time we're
> talking about but it seems to make more sense.  It appears to be IBM's
> answer to the nothing-builds-with-this-thing phenomenon, since it
> accepts a lot of GCCisms via Clang's adoption of them.  From a quick
> glance at [1], it lacks the atomics builtins but we have our own
> assembler magic for POWER.  So maybe it'd all just work™.

FWIW, I tried a test build with xlclang 16.1 on cfarm111, and
it does seem like it Just Works, modulo a couple of oddities:

* <netinet/tcp.h> fails to compile, due to references to struct
in6_addr, unless <netinet/in.h> is included first.  Most of our
references to tcp.h already do that, but not libpq-be.h and
fe-protocol3.c.  I'm a bit at a loss why we've not seen this
with the existing BF animals on this machine, because AFAICS
they're all using the same /usr/include tree.

* configure recognizes this as gcc but not Clang, which may or may
not be fine:
...
checking whether we are using the GNU C compiler... yes
...
checking whether xlclang is Clang... no
...
This doesn't seem to break anything, but it struck me as odd.
configure seems to pick a sane set of compiler options anyway.

Interestingly, xlclang shows the same failure with the pre-19fa97731
versions of timetz_zone/timetz_izone as plain xlc does.  I guess
this is not so astonishing since they presumably share the same
codegen backend.  But maybe somebody ought to file a bug with IBM?

			regards, tom lane





view thread (60+ messages)  latest in thread

Message-ID: <3032037.1697598914@sss.pgh.pa.us>
Permalink:  ../3032037.1697598914@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3032037.1697598914@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, thomas.munro@gmail.com, michael@paquier.xyz, noah@leadboat.com, vik@postgresfriends.org, hcary328@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Add support for AT LOCAL
  In-Reply-To: <3032037.1697598914@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox