From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Allowing printf("%m") only where it actually works
Date: Wed, 26 Sep 2018 11:09:59 -0400
Message-ID: <3034.1537974599@sss.pgh.pa.us> (raw)
In-Reply-To: <20180925224223.GB1659@paquier.xyz>
References: <20180925154829.rbjxmmcpd5z7ueyq@alvherre.pgsql>
<28378.1537891542@sss.pgh.pa.us>
<20180925224223.GB1659@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> On Tue, Sep 25, 2018 at 12:05:42PM -0400, Tom Lane wrote:
>> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>>> Actually I think it *is* useful to do it like this, because then the
>>> user knows to fix the netmsg.dll problem so that they can continue to
>>> investigate the winsock problem. If we don't report the secondary error
>>> message, how are users going to figure out how to fix the problem?
>> OK, I'm fine with doing it like that if people want it.
> +1.
OK, pushed 0001 with that adjustment.
While looking over the thread, I remembered I wanted to convert
strerror_r into a wrapper as well. Think I'll go do that next,
because really it'd be better for snprintf.c to be calling strerror_r
not strerror.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, alvherre@2ndquadrant.com, thomas.munro@enterprisedb.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Allowing printf("%m") only where it actually works
In-Reply-To: <3034.1537974599@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox