pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Letting plpgsql in on the fun with the new expression eval stuff
Date: Thu, 21 Dec 2017 13:00:12 -0500
Message-ID: <30461.1513879212@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+Tgmoa6eGSAqSrOsGBMh-wAQ9_KtEcXkA6Me3SBAaN6_9-JHw@mail.gmail.com>
References: <32589.1513706441@sss.pgh.pa.us>
	<20171220135602.4ixfvaqpeb6z7dil@alap3.anarazel.de>
	<27674.1513789968@sss.pgh.pa.us>
	<20171220174243.n4y3hgzf7xd3mm5e@alap3.anarazel.de>
	<24880.1513793601@sss.pgh.pa.us>
	<27734.1513802658@sss.pgh.pa.us>
	<4249.1513811175@sss.pgh.pa.us>
	<CA+Tgmoa6eGSAqSrOsGBMh-wAQ9_KtEcXkA6Me3SBAaN6_9-JHw@mail.gmail.com>

Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Dec 20, 2017 at 6:06 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Anyway, I left it as-is, but I'm willing to make the change if
>> people feel the other way is better.

> I feel the other way -- let's not add more pointer indirections if it
> isn't really necessary.

OK --- with any luck, the changes in the paramFetch API will force people
to update relevant code anyway.  It would only be an issue for code that
is not calling paramFetch at all, and such code is broken anyway for
dynamic param lists.

Pushed without touching that issue.

			regards, tom lane




view thread (9+ messages)

Message-ID: <30461.1513879212@sss.pgh.pa.us>
Permalink:  ../30461.1513879212@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/30461.1513879212@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, andres@anarazel.de, pgsql-hackers@lists.postgresql.org
  Subject: Re: Letting plpgsql in on the fun with the new expression eval stuff
  In-Reply-To: <30461.1513879212@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox