From: Tom Lane <tgl@sss.pgh.pa.us>
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Modernizing our GUC infrastructure
Date: Tue, 06 Sep 2022 01:25:14 -0400
Message-ID: <3046789.1662441914@sss.pgh.pa.us> (raw)
In-Reply-To: <CAFj8pRAqiYbZYceC4hqpUVezOE6dq4R8of5XAotaapxJzJo1eg@mail.gmail.com>
References: <2982579.1662416866@sss.pgh.pa.us>
<CAFj8pRAqiYbZYceC4hqpUVezOE6dq4R8of5XAotaapxJzJo1eg@mail.gmail.com>
Pavel Stehule <pavel.stehule@gmail.com> writes:
> The bad performance is not the main reason for implementing session
> variables (and in almost all cases the performance of GUC is not a problem,
> because it is not a bottleneck, and in some terrible cases, I can save the
> GUC to a variable). There are other differences:
Well, yeah, the schema-variables patch offers a bunch of other features.
What I'm not sure about is whether there's actually much field demand
for those. I think if we fix guc.c's performance issues and add some
simple features on top of that, like the ability to declare bool, int,
float data types not just string for a user-defined GUC, we'd have
exactly what a lot of people want --- not least because it'd be
upwards-compatible with what they are already doing.
However, that's probably a debate to have on the other thread not here.
This patch doesn't foreclose pushing forward with the schema-variables
patch, if people want that.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pavel.stehule@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Modernizing our GUC infrastructure
In-Reply-To: <3046789.1662441914@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox