From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: removal of dangling temp tables
Date: Fri, 28 Dec 2018 11:47:25 -0500
Message-ID: <30574.1546015645@sss.pgh.pa.us> (raw)
In-Reply-To: <30125.1546014939@sss.pgh.pa.us>
References: <201812281623.qlyp5nygu3pt@alvherre.pgsql>
<30125.1546014939@sss.pgh.pa.us>
I wrote:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>> I looked at
>> https://github.com/postgrespro/pg_wait_sampling/blob/master/pg_wait_sampling.c
>> https://github.com/citusdata/citus/search?q=pgproc&unscoped_q=pgproc
>> and skimmed a few others can't find any instance where the full struct
>> is used, as opposed to just a pointer to it.
> No, the point Michael is making is that the array stride in the ProcArray
> is part of our ABI. For example, accessing a PGPROC from its pgprocno
> using the GetPGProcByNumber macro will be broken if we change the
> struct size. I do not think you can assume that no extension does that.
In fact, there's a counterexample right here in pg_wait_sampling:
https://github.com/postgrespro/pg_wait_sampling/blob/master/pg_wait_sampling.c#L343
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, michael@paquier.xyz, tsunakawa.takay@jp.fujitsu.com, robertmhaas@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: removal of dangling temp tables
In-Reply-To: <30574.1546015645@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox