From: Jonathan S. Katz <jkatz@postgresql.org>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
To: michael@paquier.xyz
Cc: andres@anarazel.de
Cc: jcasanov@systemguards.com.ec
Cc: pgsql-hackers@postgresql.org
Cc: john.naylor@enterprisedb.com
Subject: Re: START_REPLICATION SLOT causing a crash in an assert build
Date: Thu, 6 Oct 2022 09:33:56 -0400
Message-ID: <3067a888-00b0-b649-eff6-36efa0484847@postgresql.org> (raw)
In-Reply-To: <20221006.141046.2033876856853955342.horikyota.ntt@gmail.com>
References: <20221006004448.6tetjuqfdg5hnkdp@awork3.anarazel.de>
<a6bff43e-f705-aaab-1271-f4885b75fbc5@postgresql.org>
<Yz5dOxZTP0vFMlwA@paquier.xyz>
<20221006.141046.2033876856853955342.horikyota.ntt@gmail.com>
On 10/6/22 1:10 AM, Kyotaro Horiguchi wrote:
> At Thu, 6 Oct 2022 13:44:43 +0900, Michael Paquier <michael@paquier.xyz> wrote in
>> On Wed, Oct 05, 2022 at 11:24:57PM -0400, Jonathan S. Katz wrote:
>>> On 10/5/22 8:44 PM, Andres Freund wrote:
>>>> I have two ideas how to fix it. As a design constraint, I'd be interested in
>>>> the RMTs opinion on the following:
>>>> Is a cleaner fix that changes the stats format (i.e. existing stats will be
>>>> thrown away when upgrading) or one that doesn't change the stats format
>>>> preferrable?
>>>
>>> [My opinion, will let Michael/John chime in]
>>>
>>> Ideally we would keep the stats on upgrade -- I think that's the better user
>>> experience.
>>
>> The release has not happened yet, so I would be fine to remain
>> flexible and bump again PGSTAT_FILE_FORMAT_ID so as we have the
>> cleanest approach in place for the release and the future.
Yes, I agree with this.
> At the
>> end, we would throw automatically the data of a file that's marked
>> with a version that does not match with what we expect at load time,
>> so there's a limited impact on the user experience, except, well,
>> losing these stats, of course.
I'm fine with this.
> +1. FWIW, the atttached is an example of what it looks like if we
> avoid file format change.
Thanks for the quick turnaround. I'll let others chime in on the review.
Thanks,
Jonathan
Attachments:
OpenPGP_signature (application/pgp-signature, 839B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: jkatz@postgresql.org, horikyota.ntt@gmail.com, michael@paquier.xyz, andres@anarazel.de, jcasanov@systemguards.com.ec, john.naylor@enterprisedb.com
Subject: Re: START_REPLICATION SLOT causing a crash in an assert build
In-Reply-To: <3067a888-00b0-b649-eff6-36efa0484847@postgresql.org>
References: <20221006004448.6tetjuqfdg5hnkdp@awork3.anarazel.de> <a6bff43e-f705-aaab-1271-f4885b75fbc5@postgresql.org> <Yz5dOxZTP0vFMlwA@paquier.xyz> <20221006.141046.2033876856853955342.horikyota.ntt@gmail.com> <3067a888-00b0-b649-eff6-36efa0484847@postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox