public inbox for [email protected]  
help / color / mirror / Atom feed
From: Tom Lane <[email protected]>
To: Heikki Linnakangas <[email protected]>
Cc: Xing Guo <[email protected]>
Cc: Andreas Karlsson <[email protected]>
Cc: [email protected]
Subject: Re: JIT: The nullness of casetest.value can be determined at the JIT compile time.
Date: Wed, 29 Jan 2025 22:29:32 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CACpMh+AiBYAWn+D1aU7Rsy-V1tox06Cbc0H3qA7rwL5zdJ=anQ@mail.gmail.com>
	<[email protected]>
	<CACpMh+AWarmG=aKy6KUyyWVTKLedBJzZMTQG3TKPN5EGVii9TA@mail.gmail.com>
	<[email protected]>

Heikki Linnakangas <[email protected]> writes:
> Huge +1 for cleaning up this abuse of caseValue_datum/domainValue_datum. 
> While correct and sensible if we continue the abuse, these patches feel 
> like putting lipstick on a pig.

Agreed.  I spent some time trying to do it better, with results
shown at [1].  If we adopt that idea, then the executor's support
for CaseTestExpr will go away, so there's little point in pursuing
that half of the patch given here.  However, I concluded that there's
insufficient reason to redesign CoerceToDomainValue, so we could
still push forward with that half of this patch.

			regards, tom lane

[1] https://www.postgresql.org/message-id/[email protected]






view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: JIT: The nullness of casetest.value can be determined at the JIT compile time.
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox