From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Piotr Stefaniak <postgres@piotr-stefaniak.me>
Subject: Re: Preliminary results for proposed new pgindent implementation
Date: Sun, 18 Jun 2017 11:42:14 -0400
Message-ID: <30855.1497800534@sss.pgh.pa.us> (raw)
In-Reply-To: <aa63eca7-00a4-a159-766a-eec4bdd338aa@2ndquadrant.com>
References: <20170519173111.zp6igkcg53egdy4s@alvherre.pgsql>
<cb9eebd2-0214-1f34-51af-ebb69ec8a711@2ndquadrant.com>
<29275.1497624664@sss.pgh.pa.us>
<aa63eca7-00a4-a159-766a-eec4bdd338aa@2ndquadrant.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 6/16/17 10:51, Tom Lane wrote:
>> So I'm back to the position that we ought to stick the indent
>> code under src/tools/ in our main repo. Is anyone really
>> seriously against that?
> I think it would be better to have it separate.
> Other than for reasons of principle and general modularity of the world,
> I would like this to be available separately for separate download,
> packaging, etc. to it can be applied to extension projects without
> having to download and build (a specific version of) PostgreSQL. The
> code formatting in extension projects is, um, questionable. In fact, if
> it's a better indent period, I would like to package it for the general
> public.
Well, the direction I'm headed in for addressing the portability issues
is to make it depend on the usual PG build environment, notably c.h and
libpgport. If we don't want it in-tree, it can be built using PGXS,
but it'll still require a PG installation somewhere in order to get built.
Making it independent of both FreeBSD and PG is a significantly larger
project, and one I don't personally intend to tackle. (And, if someone
does tackle that, I don't exactly see why having our own copy in-tree
would stop them.)
However ... off-list discussion with Piotr indicates that he's unwilling
to touch the license text without permission from FreeBSD core and/or
legal teams. While the 4-clause license is certainly no impediment to
using indent, we don't want any such text in our tree, so that seems
like a showstopper, at least until the license question is resolved.
Accordingly, I'll proceed with setting up a repo for it on
git.postgresql.org.
> If the vote is to put it into the tree, I would request not to do it in
> PG10. At this point, we should be winding things down and not open up
> new areas of activity.
I'm confused by this. Are you objecting to switching to the new indent
version for v10?
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, alvherre@2ndquadrant.com, robertmhaas@gmail.com, sfrost@snowman.net, postgres@piotr-stefaniak.me
Subject: Re: Preliminary results for proposed new pgindent implementation
In-Reply-To: <30855.1497800534@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox