public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Daniel Verite <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: Add standard collation UNICODE
Date: Fri, 12 May 2023 10:04:50 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

On 08.05.23 17:48, Peter Eisentraut wrote:
> On 27.04.23 13:44, Daniel Verite wrote:
>> This collation has an empty pg_collation.collversion column, instead
>> of being set to the same value as "und-x-icu" to track its version.
> 
>> The original patch implements this as an INSERT in which it would be 
>> easy to
>> fix I guess, but in current HEAD it comes as an entry in
>> include/catalog/pg_collation.dat:
>>
>> { oid => '963',
>>    descr => 'sorts using the Unicode Collation Algorithm with default
>> settings',
>>    collname => 'unicode', collprovider => 'i', collencoding => '-1',
>>    colliculocale => 'und' },
>>
>> Should it be converted back into an INSERT or better left
>> in this file and collversion being updated afterwards?
> 
> How about we do it with an UPDATE command.  We already do this for 
> pg_database in a similar way.  See attached patch.

This has been committed.

view thread (6+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Add standard collation UNICODE
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox