From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Petr Jelinek <petr@2ndquadrant.com>
Cc: Tatsuo Ishii <ishii@postgresql.org>
Cc: jeff.janes@gmail.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: multivariate statistics v14
Date: Mon, 28 Mar 2016 10:49:10 +0200
Message-ID: <3112096b-7d8f-6313-ff93-ce236e87d4d6@2ndquadrant.com> (raw)
In-Reply-To: <20160326190933.GA725919@alvherre.pgsql>
References: <20160326190933.GA725919@alvherre.pgsql>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 03/26/2016 08:09 PM, Alvaro Herrera wrote:
> Tomas Vondra wrote:
>
>> There are a few places where I reverted the pgindent formatting, because it
>> seemed a bit too weird - the first one are the lists of function prototypes
>> in common.h/mvstat.h, the second one are function calls to
>> _greedy/_exhaustive methods.
>
> Function prototypes being weird is something that we've learned to
> accept. There's no point in undoing pgindent decisions there, because
> the next run will re-apply them anyway. Best not to fight it.
>
> What you should definitely look into fixing is the formatting of
> comments, if the result is too horrible. You can prevent it from
> messing those by adding dashes /*----- at the beginning of the comment.
>
Yep, formatting of some of the comments got slightly broken, but it
wasn't difficult to fix that without the /*------- trick.
I'm not sure about the prototypes though. It was a bit weird because
prototypes in the same header file were formatted very differently.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tomas.vondra@2ndquadrant.com, alvherre@2ndquadrant.com, tgl@sss.pgh.pa.us, petr@2ndquadrant.com, ishii@postgresql.org, jeff.janes@gmail.com
Subject: Re: multivariate statistics v14
In-Reply-To: <3112096b-7d8f-6313-ff93-ce236e87d4d6@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox