From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: WIP: Faster Expression Processing v4
Date: Wed, 22 Mar 2017 10:41:06 -0400
Message-ID: <31150.1490193666@sss.pgh.pa.us> (raw)
In-Reply-To: <20170320062511.hp5qeurtxrwsvfxr@alap3.anarazel.de>
References: <20161206034955.bh33paeralxbtluv@alap3.anarazel.de>
<20170209003312.rr7atqepgbrf4xqe@alap3.anarazel.de>
<20170307030137.lpo4japv5oqgbqpz@alap3.anarazel.de>
<2090fd00-4dec-7b42-f700-64308958504c@2ndquadrant.com>
<20170313080351.4g5oubxcj4xj5y7t@alap3.anarazel.de>
<fcdaa51b-e905-72e0-39dd-5e22f535a253@2ndquadrant.com>
<20170314065259.ffef4tfhgbsaieoe@alap3.anarazel.de>
<69b7bb0e-8dab-3d39-1a89-3c6ab6409f64@iki.fi>
<20170314224706.nxvtapenky6eom3z@alap3.anarazel.de>
<13062.1489622943@sss.pgh.pa.us>
<20170320062511.hp5qeurtxrwsvfxr@alap3.anarazel.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
I've been busily hacking away on this, trying to make things cleaner and
fix a couple of bugs I stumbled across. (Confusion between ExecQual and
ExecCheck, for instance - we apparently lack regression tests exercising
constraints-returning-null in corner cases such as table rewrite.) It
will probably be a day or two more before I'm done.
A couple of naming questions:
* I concur with Heikki's dislike for the file name execInterpExpr.c.
Would it make it any better to switch to execExprInterp.c? I think
that having all this stuff under a common pattern execExpr*.c would
be a good thing (and I notice you've already got one comment referring
to them that way ...)
* execQual.c doesn't seem to have a unifying reason to exist anymore.
It certainly has little to do with evaluating typical qual expressions;
what's left in there seems to be mostly concerned with SRFs. I feel
like it might be a good idea to rename it, but to what? execExprUtils.c
perhaps? Or maybe we should destroy it altogether, shoving the SRF
stuff into nodeFunctionscan.c and moving what little remains into
execUtils.c.
* I do not like the function name ExecInstantiateExpr(). Webster's
defines "instantiate" as "to represent (an abstraction) by a concrete
instance", which does not seem to me to have a lot to do with what this
function actually does. There's nothing very abstract about its input.
More, the implication of "instantiate" is that you can instantiate any
number of representatives of the same abstraction, but this scribbles
on the input in a one-way fashion. I think perhaps something like
ExecPrepareExpr or ExecFinishExpr or something along that line would
be better, but nothing is really standing out as le mot juste.
Thoughts?
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, hlinnaka@iki.fi, tomas.vondra@2ndquadrant.com
Subject: Re: WIP: Faster Expression Processing v4
In-Reply-To: <31150.1490193666@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox