pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <david.rowley@2ndquadrant.com>
Cc: Mark Dilger <hornschnorter@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: "SELECT ... FROM DUAL" is not quite as silly as it appears
Date: Mon, 14 Jan 2019 19:17:24 -0500
Message-ID: <31228.1547511444@sss.pgh.pa.us> (raw)
In-Reply-To: <CAKJS1f9RAWOscHa0Tboo4XhgaMqq_hHhXdapsxGV-Yru4mzr-g@mail.gmail.com>
References: <15944.1521127664@sss.pgh.pa.us>
	<9565.1539573909@sss.pgh.pa.us>
	<154342395130.2093.8013327151440360209.pgcf@coridan.postgresql.org>
	<12357.1543518669@sss.pgh.pa.us>
	<CAKJS1f-ZRNnb7-NxY1odPR=ZjEiJx=_094aQZsEvJ6JEnzDjKg@mail.gmail.com>
	<20472.1546631337@sss.pgh.pa.us>
	<CAKJS1f8OKaw4LV6rTf4gedO97fzgo-V6bFOoC-r4UK6Fdaex=Q@mail.gmail.com>
	<21565.1547498912@sss.pgh.pa.us>
	<CAKJS1f9RAWOscHa0Tboo4XhgaMqq_hHhXdapsxGV-Yru4mzr-g@mail.gmail.com>

David Rowley <david.rowley@2ndquadrant.com> writes:
> 1. I don't think having a table named "dual" makes a whole lot of
> sense for a table with a single row.

Well, I borrowed Oracle terminology there ;-)

> (Uppercasing these additions would also make them look less of an afterthought.)

Don't really care, can do.

> I also did a quick benchmark of v6 and found the slowdown to be
> smaller after the change made in build_simple_rel()

Thanks for confirming.  I was not very sure that was worth the extra
few bytes of code space, but if you see a difference too, then it's
probably worthwhile.

			regards, tom lane




view thread (33+ messages)  latest in thread

Message-ID: <31228.1547511444@sss.pgh.pa.us>
Permalink:  ../31228.1547511444@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/31228.1547511444@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, david.rowley@2ndquadrant.com, hornschnorter@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: "SELECT ... FROM DUAL" is not quite as silly as it appears
  In-Reply-To: <31228.1547511444@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox