pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Shawn Debnath <sdn@amazon.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Refactoring the checkpointer's fsync request queue
Date: Tue, 05 Mar 2019 11:53:16 -0500
Message-ID: <3127.1551804796@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+hUKGJX302ctT26zXc1w7PvrwcUWHNUH0casYhA6Si0d7xDng@mail.gmail.com>
References: <20190222224853.ahvm3bf52zqr7k7h@alap3.anarazel.de>
	<CA+hUKG+i5+0Grt9O9gtv1YHASP6R3rfb8074or0j=fFoY6YvTw@mail.gmail.com>
	<20190222230916.5mfsqn3oesd2nxiz@alap3.anarazel.de>
	<20190222234549.GA7397@f01898859afd.ant.amazon.com>
	<20190222235742.4oed46wocpjfpoa5@alap3.anarazel.de>
	<20190227212653.GA7171@f01898859afd.ant.amazon.com>
	<CA+hUKG+2EuoDhVBdieOKnneFX14SeuRp7z0WG2PSOMJt8ks3qw@mail.gmail.com>
	<CA+hUKGKF7QvUi2ST4R5vd_PVdcztBTXB23ZJwoj_ASoujrbsmQ@mail.gmail.com>
	<2a1667c64cc0485bb781704876ac5a0a@EX13D05UWC002.ant.amazon.com>
	<CA+hUKGLiUQ2mMQBTencjZKt88io5m7eguRmuxbaPqPTyL6ERtg@mail.gmail.com>
	<20190305160715.GA26468@f01898859afd.ant.amazon.com>
	<CA+hUKGJX302ctT26zXc1w7PvrwcUWHNUH0casYhA6Si0d7xDng@mail.gmail.com>

Thomas Munro <thomas.munro@gmail.com> writes:
> +#include "fmgr.h"
> +#include "storage/block.h"
> +#include "storage/relfilenode.h"
> +#include "storage/smgr.h"
> +#include "storage/sync.h"

> Why do we need to include fmgr.h in md.h?

More generally, any massive increase in an include file's inclusions
is probably a sign that you need to refactor.  Cross-header inclusions
are best avoided altogether if you can --- obviously that's not always
possible, but we should minimize them.  We've had some very unfortunate
problems in the past from indiscriminate #includes in headers.

			regards, tom lane




view thread (87+ messages)  latest in thread

Message-ID: <3127.1551804796@sss.pgh.pa.us>
Permalink:  ../3127.1551804796@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3127.1551804796@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, thomas.munro@gmail.com, sdn@amazon.com, andres@anarazel.de, 9erthalion6@gmail.com, robertmhaas@gmail.com
  Subject: Re: Refactoring the checkpointer's fsync request queue
  In-Reply-To: <3127.1551804796@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox