public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Gurjeet Singh <[email protected]>
Cc: Postgres Hackers <[email protected]>
Subject: Re: lwlocknames.h beautification attempt
Date: Sun, 02 Mar 2025 02:00:33 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CABwTF4VK4sFjdm9kE9CcWW1p2MGDBW4qhA_Sibcy=9fj+oP8bg@mail.gmail.com>
References: <CABwTF4VxfwDtRV-H22_XK4XeDogaV-Vaobu+af5U=8ZAZn9ZZQ@mail.gmail.com>
	<[email protected]>
	<CABwTF4VK4sFjdm9kE9CcWW1p2MGDBW4qhA_Sibcy=9fj+oP8bg@mail.gmail.com>

Gurjeet Singh <[email protected]> writes:
> On Sat, Mar 1, 2025 at 10:26 PM Tom Lane <[email protected]> wrote:
>> This looks reasonably in line with project style ...

> Should I create a commitfest entry for this patch, or is it
> uncontroversial enough and small enough to not warrant that?

The controversy would be more about whether it's worth bothering
with.  In the past we've taken some care to ensure that generated
files would pass pgindent's ideas of correct formatting, but
not more than that.  AFAICT from some quick tests, pgindent has
no opinions about layout of #define lines.

			regards, tom lane

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: lwlocknames.h beautification attempt
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox