pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Noah Misch <noah@leadboat.com>
Cc: Amit Khandekar <amitdkhan.pg@gmail.com>
Cc: Alvaro Herrera from 2ndQuadrant <alvherre@alvh.no-ip.org>
Cc: Andres Freund <andres@anarazel.de>
Cc: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Subject: Re: logical decoding : exceeded maxAllocatedDescs for .spill files
Date: Sat, 11 Jan 2020 00:46:19 -0500
Message-ID: <31443.1578721579@sss.pgh.pa.us> (raw)
In-Reply-To: <CAA4eK1KdmUTUaRfUhViLimgEk-u4tVE9F-_N=Xk+Dyvh95H67g@mail.gmail.com>
References: <CAA4eK1+fogKCWvFzkEbSn5O7HQ-Xo+RKOtFf8=+tfqOzxd21dg@mail.gmail.com>
	<CAJ3gD9dV9SBCoMOJDZPDrB9-W74UpMvEeL+DBqg2Yg2BSmQstQ@mail.gmail.com>
	<CAA4eK1JdK+-uz_fXOo+p6no7jxvthjmxDkqyqC2bmKvHXiRUjw@mail.gmail.com>
	<CAJ3gD9edQpM6XkNGaaQ1eN9698-DOiQbF8UoseVXAQPwT0Se7A@mail.gmail.com>
	<CAA4eK1JSEn=UuTiYiAwqAWWEmLvMtnPMQ2+my0X8diEgtG6LqA@mail.gmail.com>
	<CAA4eK1LMDx6vK8Kdw8WUeW1MjToN2xVffL2kvtHvZg17=Y6QQg@mail.gmail.com>
	<CAA4eK1LJqMuXoCLuxkTr1HidbR8DkgRrVC7jHWDyXT=FD2gt6Q@mail.gmail.com>
	<CAJ3gD9dFYJnOxUsR3MeJ=3hJKZk5XqAx-6fYUNXt6jJOK3QFMQ@mail.gmail.com>
	<20200104185148.GA2270238@rfd.leadboat.com>
	<CAJ3gD9diTB8rqyUWo=jZrSQxvW7o-gGaO6uoF5racneH3+FYOg@mail.gmail.com>
	<20200109053704.GA2502006@rfd.leadboat.com>
	<22498.1578548741@sss.pgh.pa.us>
	<CAA4eK1JitJgbOv-ie3VCXW5A74j-v0b8S55YMunwmkFDZ_4NCg@mail.gmail.com>
	<14739.1578613901@sss.pgh.pa.us>
	<18117.1578616812@sss.pgh.pa.us>
	<CAA4eK1LATyRWPNbLSR2BM+Hn5t-xeyMT+C9+sUrkgYvm5+QLoQ@mail.gmail.com>
	<CAA4eK1KdmUTUaRfUhViLimgEk-u4t! VE9F-_N=Xk+Dyvh95H67g@mail.gmail.com>

Amit Kapila <amit.kapila16@gmail.com> writes:
> On Fri, Jan 10, 2020 at 9:31 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
>> ... So, we have the below
>> options:
>> (a) remove this test entirely from all branches and once we found the
>> memory leak problem in back-branches, then consider adding it again
>> without max_files_per_process restriction.
>> (b) keep this test without max_files_per_process restriction till v11
>> and once the memory leak issue in v10 is found, we can back-patch to
>> v10 as well.

> I am planning to go with option (a) and attached are patches to revert
> the entire test on HEAD and back branches.  I am planning to commit
> these by Tuesday unless someone has a better idea.

Makes sense to me.  We've certainly found out something interesting
from this test, but not what it was expecting to find ;-).  I think
that there could be scope for two sorts of successor tests:

* I still like my idea of directly constraining max_safe_fds through
some sort of debug option.  But to my mind, we want to run the entire
regression suite with that restriction, not just one small test.

* The seeming bug in v10 suggests that we aren't testing large enough
logical-decoding cases, or at least aren't noticing leaks in that
area.  I'm not sure what a good design is for testing that.  I'm not
thrilled with just using a larger (and slower) test case, but it's
not clear to me how else to attack it.

			regards, tom lane





view thread (114+ messages)  latest in thread

Message-ID: <31443.1578721579@sss.pgh.pa.us>
Permalink:  ../31443.1578721579@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/31443.1578721579@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, amit.kapila16@gmail.com, noah@leadboat.com, amitdkhan.pg@gmail.com, alvherre@alvh.no-ip.org, andres@anarazel.de, juanjo.santamaria@gmail.com, pgsql-hackers@lists.postgresql.org, robertmhaas@gmail.com, thomas.munro@gmail.com, tomas.vondra@2ndquadrant.com
  Subject: Re: logical decoding : exceeded maxAllocatedDescs for .spill files
  In-Reply-To: <31443.1578721579@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox