pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: David Rowley <david.rowley@2ndquadrant.com>
Cc: Jeff Janes <jeff.janes@gmail.com>
Cc: Jeremy Schneider <schnjere@amazon.com>
Cc: Joe Conway <mail@joeconway.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Should we increase the default vacuum_cost_limit?
Date: Sun, 10 Mar 2019 11:47:17 -0400
Message-ID: <31554.1552232837@sss.pgh.pa.us> (raw)
In-Reply-To: <CAOBaU_Z8k1RAB8u761qg-L9EKZzywwiJde=hiuBRN6hvE8+7vQ@mail.gmail.com>
References: <CAKJS1f_YbXC2qTMPyCbmsPiKvZYwpuQNQMohiRXLj1r=8_rYvw@mail.gmail.com>
	<CAH2-Wz=WQ9ju6sjPF7RcW0g6NPXAenZeC5qVme6uj+eMRw5q2g@mail.gmail.com>
	<241b80ab-7af0-c606-7b2c-b0a5d6be696a@joeconway.com>
	<CAKJS1f_5xofbg0K16MkhQPeCXV6oGCuD2SVcV76OW7ydFDHDkw@mail.gmail.com>
	<df548503-d261-d8c4-97d0-61be6617df41@2ndQuadrant.com>
	<4a068b09-5a6f-e975-07c9-2333fcef0a8a@amazon.com>
	<30411a5b-ef11-71ef-e9ee-4d26ef3fd0c0@2ndQuadrant.com>
	<CAMkU=1zM7sK9Xo2jjwCLj-t+GHR5nQJnPyFUp+puBiFpOQ7aBA@mail.gmail.com>
	<21034.1552068630@sss.pgh.pa.us>
	<CAKJS1f9wbS+SzEDUXyMuLCsNgwMH=1Ztj3QE3WxuKdJtbqrOEA@mail.gmail.com>
	<13d143dd-0a44-0c16-218c-bc924b5922f0@2ndQuadrant.com>
	<26656.1552096451@sss.pgh.pa.us>
	<28720.1552101086@sss.pgh.pa.us>
	<CAKJS1f8s5Cxat65_-uE97oUpoonO3p_2rFMf-cKA7kpAaS1-OA@mail.gmail.com>
	<203719fc-1970-4a49-8013-eba3fd109b19@2ndQuadrant.com>
	<24300.1552154154@sss.pgh.pa.us>
	<c88dc1b3-9d2c-5a87-717c-0fb2497b1f22@2ndQuadrant.com>
	<CAOBaU_Y8n9pmuRKeXUzUb_pPZmL-Nm601p_MdEMHBcBGp4W0UQ@! mail.gmail.com>
	<1798.1552165479@sss.pgh.pa.us>
	<CAOBaU_Z8k1RAB8u761qg-L9EKZzywwiJde=hiuBRN6hvE8+7vQ@mail.gmail.com>

Julien Rouhaud <rjuju123@gmail.com> writes:
> On Sat, Mar 9, 2019 at 10:04 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I tried this, and it seems to work pretty well.  The first of the two
>> attached patches just teaches guc.c to support units for float values,
>> incidentally allowing "us" as an input unit for time-based GUCs.

> Why not allowing third party extensions to declare a GUC stored in us?

I think that adding a new base unit type (GUC_UNIT_US) is possible but
I'm disinclined to do it on the basis of zero evidence that it's needed.
Only three of the five already-known time units are allowed to be base
units (ms, s, min are but d and h aren't) so it's not like there's no
precedent for excluding this one.  Anyway, such a patch would be mostly
orthogonal to what I've done here, so it should be considered on its
own merits.

(BTW, if we're expecting to have GUCs that are meant to measure only
very short time intervals, maybe it'd be more forward-looking for
their base unit to be NS not US.)

>> 2. It's always bugged me that we don't allow fractional unit
>> specifications, say "0.1GB", even for GUCs that are integers underneath.
>> That would be a simple additional change on top of this, but I didn't
>> do it here.

> It annoyed me multiple times, so +1 for making that happen.

OK, will do.

			regards, tom lane




view thread (44+ messages)  latest in thread

Message-ID: <31554.1552232837@sss.pgh.pa.us>
Permalink:  ../31554.1552232837@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/31554.1552232837@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, rjuju123@gmail.com, andrew.dunstan@2ndquadrant.com, david.rowley@2ndquadrant.com, jeff.janes@gmail.com, schnjere@amazon.com, mail@joeconway.com, pg@bowt.ie, pgsql-hackers@lists.postgresql.org
  Subject: Re: Should we increase the default vacuum_cost_limit?
  In-Reply-To: <31554.1552232837@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox