From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Jeff Janes <jeff.janes@gmail.com>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: Reducing pg_ctl's reaction time
Date: Wed, 28 Jun 2017 14:29:07 -0400
Message-ID: <318.1498674547@sss.pgh.pa.us> (raw)
In-Reply-To: <20170628173457.yhq7zmfhjdcfvkto@alap3.anarazel.de>
References: <19812.1498510147@sss.pgh.pa.us>
<20170626205853.ezhnmxpotdy3wokm@alap3.anarazel.de>
<15166.1498512630@sss.pgh.pa.us>
<20170626213414.ejcesidei2hv4h5x@alap3.anarazel.de>
<15732.1498513083@sss.pgh.pa.us>
<20170626215018.2fudv2aha5rkkg4r@alap3.anarazel.de>
<17327.1498515236@sss.pgh.pa.us>
<15323.1498589958@sss.pgh.pa.us>
<20170627200544.2czwjtdtyy4gr4sv@alap3.anarazel.de>
<30238.1498671087@sss.pgh.pa.us>
<20170628173457.yhq7zmfhjdcfvkto@alap3.anarazel.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Andres Freund <andres@anarazel.de> writes:
> On 2017-06-28 13:31:27 -0400, Tom Lane wrote:
>> While looking this over again, I got worried about the fact that pg_ctl
>> is #including "miscadmin.h". That's a pretty low-level backend header
>> and it wouldn't be surprising at all if somebody tried to put stuff in
>> it that wouldn't compile frontend-side. I think we should take the
>> opportunity, as long as we're touching this stuff, to split the #defines
>> that describe the contents of postmaster.pid into a separate header file.
>> Maybe "utils/pidfile.h" ?
> Yes, that sounds like a valid concern, and solution.
So when I removed the miscadmin.h include, I found out that pg_ctl is
also relying on PG_BACKEND_VERSIONSTR from that file.
There are at least three things we could do here:
1. Give this up as not worth this much trouble.
2. Move PG_BACKEND_VERSIONSTR into pg_config.h to go along with the
other version-related macros.
3. Give PG_BACKEND_VERSIONSTR its very own new header file.
Any preferences?
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, jeff.janes@gmail.com, michael.paquier@gmail.com
Subject: Re: Reducing pg_ctl's reaction time
In-Reply-To: <318.1498674547@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox