public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Daniel Gustafsson <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: evtcache: EventTriggerCache vs Event Trigger Cache
Date: Thu, 04 May 2023 08:09:12 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

Daniel Gustafsson <[email protected]> writes:
> When reading a memory contexts log I realized that we have this:
> LOG:  level: 2; EventTriggerCache: 8192 total in 1 blocks; 7928 free (4 chunks); 264 used
> LOG:  level: 3; Event Trigger Cache: 8192 total in 1 blocks; 2616 free (0 chunks); 5576 used

> The reason is that BuildEventTriggerCache sets up a context "EventTriggerCache"
> which house a hash named "Event Trigger Cache" which in turn creates a context
> with the table name.  I think it makes sense that these share the same name,
> but I think it would be less confusing if they also shared the same spelling
> whitespace-wise.  Any reason to not rename the hash EventTriggerCache to make
> the logging a tiny bit easier to read and grep?

Hmm, I'm kinda -1 on them having the same name visible in the
contexts dump --- that seems very confusing.  How about naming
the hash "EventTriggerCacheHash" or so?

			regards, tom lane

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: evtcache: EventTriggerCache vs Event Trigger Cache
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox