pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Anton A. Melnikov <aamelnikov@inbox.ru>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Richard Guo <guofenglinux@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org, "Finnerty, Jim" <jfinnert@amazon.com>
Subject: Re: Making Vars outer-join aware
Date: Thu, 04 May 2023 08:22:04 -0400
Message-ID: <3197069.1683202924@sss.pgh.pa.us> (raw)
In-Reply-To: <5b370a46-f6d2-373d-9dbc-0d55250e82c1@inbox.ru>
References: <1035990.1667261942@sss.pgh.pa.us>
	<2901865.1667685211@sss.pgh.pa.us>
	<CAMbWs4_pH7w7voY0AejUM4RiKq-Xuf+sXmoF8PcQwzNrsagEXA@mail.gmail.com>
	<CAMbWs4_gXgGdkkOraUPEoZD_Q3xTW7FTxfomW+fxPN2Kr-YSXg@mail.gmail.com>
	<4019771.1672155080@sss.pgh.pa.us>
	<CAMbWs4_JDDdXvEBWtTao9ZTwOGdDCU7X-=bF7yi9G1u_-b0Dfw@mail.gmail.com>
	<323812.1672241806@sss.pgh.pa.us>
	<2043562.1674506286@sss.pgh.pa.us>
	<20230212235823.GW1653@telsasoft.com>
	<CAMbWs4-K8_yqARnrmRB5=xAWTJGgTpimQinvaa-k6c8f6Hideg@mail.gmail.com>
	<20230213184807.GF1653@telsasoft.com>
	<5b370a46-f6d2-373d-9dbc-0d55250e82c1@inbox.ru>

"Anton A. Melnikov" <aamelnikov@inbox.ru> writes:
> The thing is that for custom scan nodes as readme says:
> "INDEX_VAR is abused to signify references to columns of a custom scan tuple type"
> But INDEX_VAR has a negative value, so it can not be used in varnullingrels bitmapset.
> And therefore this improvement seems will not work with custom scan nodes and some
> extensions that use such nodes.

Under what circumstances would you be trying to inject INDEX_VAR
into a nullingrel set?  Only outer-join relids should ever appear there.
AFAICS the change you propose would serve only to mask bugs.

			regards, tom lane





view thread (60+ messages)  latest in thread

Message-ID: <3197069.1683202924@sss.pgh.pa.us>
Permalink:  ../3197069.1683202924@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3197069.1683202924@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, aamelnikov@inbox.ru, pryzby@telsasoft.com, guofenglinux@gmail.com, jfinnert@amazon.com
  Subject: Re: Making Vars outer-join aware
  In-Reply-To: <3197069.1683202924@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox