From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org, Maciek Sakrejda <m.sakrejda@gmail.com>
Cc: Hunaid Sohail <hunaidpgml@gmail.com>
Subject: Re: Test improvements and minor code fixes for formatting.c.
Date: Thu, 26 Sep 2024 11:04:33 -0400
Message-ID: <320335.1727363073@sss.pgh.pa.us> (raw)
In-Reply-To: <Zun7yZP4AL8gVLEH@nathan>
References: <2956175.1725831136@sss.pgh.pa.us>
<Zun7yZP4AL8gVLEH@nathan>
Nathan Bossart <nathandbossart@gmail.com> writes:
> On Sun, Sep 08, 2024 at 05:32:16PM -0400, Tom Lane wrote:
>> In looking at this, I found that there's also no test coverage
>> for the EEEE, V, or PL format codes. Also, the possibility of
>> overflow while converting an input value to int in order to
>> pass it to int_to_roman was ignored. Attached is a patch that
>> adds more test coverage and cleans up the Roman-numeral code
>> a little bit.
> I stared at the patch for a while, and it looks good to me.
Pushed, thanks for looking!
>> BTW, I also discovered that there is a little bit of support
>> for a "B" format code: we can parse it, but then we ignore it.
> AFAICT it's been like that since it was introduced [0]. I searched the
> archives and couldn't find any discussion about this format code. Given
> that, I don't have any concerns about removing it unless it causes ERRORs
> for calls that currently succeed, but even then, it's probably fine. This
> strikes me as something that might be fun for an aspiring hacker, though.
Yeah, I left that alone for now. I don't have much interest in
making it work, but perhaps someone else will.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, nathandbossart@gmail.com, m.sakrejda@gmail.com, hunaidpgml@gmail.com
Subject: Re: Test improvements and minor code fixes for formatting.c.
In-Reply-To: <320335.1727363073@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox