From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Reducing the runtime of the core regression tests
Date: Wed, 10 Apr 2019 19:19:38 -0400
Message-ID: <32387.1554938378@sss.pgh.pa.us> (raw)
In-Reply-To: <CAH2-WznCYL49ci=Gvq-WqRoTOESBfNCkQRbw=zzJ-zRrp6dedQ@mail.gmail.com>
References: <735.1554935715@sss.pgh.pa.us>
<CAH2-WznCYL49ci=Gvq-WqRoTOESBfNCkQRbw=zzJ-zRrp6dedQ@mail.gmail.com>
Peter Geoghegan <pg@bowt.ie> writes:
> On Wed, Apr 10, 2019 at 3:35 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> * Likewise, I split up indexing.sql by moving the "fastpath" test into
>> a new file index_fastpath.sql.
> I just noticed that the "fastpath" test actually fails to test the
> fastpath optimization -- the coverage we do have comes from another
> test in btree_index.sql, that I wrote back in December.
Oh! Hmm.
> I'll come up with a patch to deal with this situation, by
> consolidating the old and new tests in some way. I don't think that
> your work needs to block on that, though.
Should I leave out the part of my patch that creates index_fastpath.sql?
If we're going to end up removing that version of the test, there's no
point in churning the related lines beforehand.
One way or the other I want to get that test out of where it is,
because indexing.sql is currently the slowest test in its group.
But if you prefer to make btree_index run a bit longer rather than
inventing a new test script, that's no problem from where I stand.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pg@bowt.ie, pgsql-hackers@lists.postgresql.org
Subject: Re: Reducing the runtime of the core regression tests
In-Reply-To: <32387.1554938378@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox