From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: Sawada Masahiko <sawada.mshk@gmail.com>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] More stats about skipped vacuums
Date: Wed, 07 Feb 2018 16:59:20 -0500
Message-ID: <3246.1518040760@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+Tgmoa0e23YC3SCwB85Yf5oUTRyirV=Sq_rXYxaXABLdPpjoA@mail.gmail.com>
References: <20171211.201523.24172046.horiguchi.kyotaro@lab.ntt.co.jp>
<CAD21AoCRn6Q0wGG7UwGVsQJZbocNsRaZByJomUy+-GRkVH-i9A@mail.gmail.com>
<20180206.192437.229464841.horiguchi.kyotaro@lab.ntt.co.jp>
<20180207.103458.192443145.horiguchi.kyotaro@lab.ntt.co.jp>
<CA+Tgmoa0e23YC3SCwB85Yf5oUTRyirV=Sq_rXYxaXABLdPpjoA@mail.gmail.com>
Robert Haas <robertmhaas@gmail.com> writes:
> It seems to me that there was a thread where Tom proposed removing
> support for dynamic_shared_memory_type = none.
I think you're recalling <32138.1502675970@sss.pgh.pa.us>, wherein
I pointed out that
>>> Whether that's worth the trouble is debatable. The current code
>>> in initdb believes that every platform has some type of DSM support
>>> (see choose_dsm_implementation). Nobody's complained about that,
>>> and it certainly works on every buildfarm animal. So for all we know,
>>> dynamic_shared_memory_type = none is broken already.
(That was in fact in the same thread Kyotaro-san just linked to about
reimplementing the stats collector.)
It's still true that we've no reason to believe there are any supported
platforms that haven't got some sort of DSM. Performance might be a
different question, of course ... but it's hard to believe that
transferring stats through DSM wouldn't be better than writing them
out to files.
> I suggest we remove support for dynamic_shared_memory_type = none first,
> and see if we get any complaints. If we don't, then future patches can
> rely on it being present.
If we remove it in v11, it'd still be maybe a year from now before we'd
have much confidence from that alone that nobody cares. I think the lack
of complaints about it in 9.6 and 10 is a more useful data point.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, horiguchi.kyotaro@lab.ntt.co.jp, sawada.mshk@gmail.com, michael.paquier@gmail.com
Subject: Re: [HACKERS] More stats about skipped vacuums
In-Reply-To: <3246.1518040760@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox