From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jesse Zhang <sbjesse@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: run pgindent on a regular basis / scripted manner
Date: Wed, 12 Aug 2020 19:47:01 -0400
Message-ID: <328084.1597276021@sss.pgh.pa.us> (raw)
In-Reply-To: <CAGf+fX71Oa2vzg0xdj+vgrjmdVrm=kRLc7H3SEGtCHkGhoWDCg@mail.gmail.com>
References: <20200812223409.6di3y2qsnvynao7a@alap3.anarazel.de>
<CAGf+fX71Oa2vzg0xdj+vgrjmdVrm=kRLc7H3SEGtCHkGhoWDCg@mail.gmail.com>
Jesse Zhang <sbjesse@gmail.com> writes:
> On Wed, Aug 12, 2020 at 3:34 PM Andres Freund wrote:
>> Is there any reason we don't just automatically run pgindent regularly?
>> Like once a week? And also update typedefs.list automatically, while
>> we're at it?
> You know what's better than weekly? Every check-in.
I'm not in favor of unsupervised pgindent runs, really. It can do a lot
of damage to code that was written without thinking about it --- in
particular, it'll make a hash of comment blocks that were manually
formatted and not protected with dashes.
If the workflow is commit first and re-indent later, then we can always
revert the pgindent commit and clean things up manually; but an auto
re-indent during commit wouldn't provide that history.
I do like the idea of more frequent, smaller pgindent runs instead of
doing just one giant run per year. With the giant runs it's necessary
to invest a fair amount of time eyeballing all the changes; if we did it
every couple weeks then the pain would be a lot less.
Another idea would be to have a bot that runs pgindent *without*
committing the results, and emails the people who have made commits
into files that changed, saying "if you don't like these diffs then
you'd better clean up your commit before it happens for real". With
some warning like that, it might be okay to do automatic reindenting
a little bit later. Plus, nagging committers who habitually commit
improperly-indented code might persuade them to clean up their acts ;-)
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, sbjesse@gmail.com, andres@anarazel.de
Subject: Re: run pgindent on a regular basis / scripted manner
In-Reply-To: <328084.1597276021@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox