pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Corey Huinker <corey.huinker@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Nikita Glukhov <n.gluhov@postgrespro.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Error-safe user functions
Date: Mon, 05 Dec 2022 11:09:27 -0500
Message-ID: <3304244.1670256567@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+Tgmoa-A61npwUqzGs7J-tt6RaCwOx-p=cx+Xss=fyjeSTDew@mail.gmail.com>
References: <3bbbb0df-7382-bf87-9737-340ba096e034@postgrespro.ru>
	<3190059.1665164276@sss.pgh.pa.us>
	<57b7cc2e-1215-3f43-84e4-6d9f8ad575df@dunslane.net>
	<CADkLM=djieyppZpKgveeDdt3QYLt+XQGHzpoa+Sd_Lwa5dDTWA@mail.gmail.com>
	<3049337.1669008405@sss.pgh.pa.us>
	<469338a3-da38-160f-23b9-813c261bc1d6@dunslane.net>
	<1677334.1669918475@sss.pgh.pa.us>
	<CA+TgmoY44nbY6Z7zbnQ1VwgDu79DbOHmh4o8K9cBu0OeC2Hndw@mail.gmail.com>
	<1695760.1669923671@sss.pgh.pa.us>
	<CA+TgmobpfOx0WT+ZG71eB5=JrKUi-VX7FwsVF6E8ps1WfKYYcQ@mail.gmail.com>
	<1703871.1669927782@sss.pgh.pa.us>
	<CA+TgmoaxLcxpLmFJ=QiOThfPRGLhRH+o2XZmVie2KOk5TKGbKg@mail.gmail.com>
	<1721519.1669934025@sss.pgh.pa.us>
	<CA+TgmoZ5tQz4sZfXOAK-wx7e2d2+pGg4EEc1TA4sb9gNMjm4Fw@mail.gmail.com>
	<1925585.1669990324@sss.pgh.pa.us>
	<02cf2f81-a776-37ff-291c-100480722a5c@dunslane.net>
	<2503569.1670104001@sss.pgh.pa.us>
	<CADkLM=end5RBrsQMfyB8VxvOmu5AZzsffQbDJge3TjtkxUGkEQ@mail.gmail.com>
	<CA+Tgmoa-A61npwUqzGs7J-tt6RaCwOx-p=cx+Xss=fyjeSTDew@mail.gmail.com>

Robert Haas <robertmhaas@gmail.com> writes:
> On Sat, Dec 3, 2022 at 10:57 PM Corey Huinker <corey.huinker@gmail.com> wrote:
>> 2. ereturn_* => errfeedback / error_feedback / feedback

> Oh, I like that, especially errfeedback.

efeedback?  But TBH I do not think any of these are better than ereturn.

Whether or not you agree with my position that it'd be best if the new
macro name is the same length as "ereport", I hope we can all agree
that it had better be short.  ereport call nests already tend to contain
quite long lines.  We don't need to add another couple tab-stops worth
of indentation there.

As for it being the same length: if you take a close look at my 0002
patch, you will realize that replacing ereport with a different-length
name will double or triple the number of lines that need to be touched
in many input functions.  Yeah, we could sweep that under the rug to
some extent by submitting non-pgindent'd patches and running a separate
pgindent commit later, but that is not without pain.  I don't want to
go there for the sake of a name that isn't really compellingly The
Right Word, and "feedback" just isn't very compelling IMO.

			regards, tom lane





view thread (175+ messages)  latest in thread

Message-ID: <3304244.1670256567@sss.pgh.pa.us>
Permalink:  ../3304244.1670256567@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3304244.1670256567@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, corey.huinker@gmail.com, andrew@dunslane.net, n.gluhov@postgrespro.ru, pgsql-hackers@lists.postgresql.org
  Subject: Re: Error-safe user functions
  In-Reply-To: <3304244.1670256567@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox