public inbox for [email protected]help / color / mirror / Atom feed
[PATCH v24 04/10] default to --with-lz4 3+ messages / 3 participants [nested] [flat]
* [PATCH v24 04/10] default to --with-lz4 @ 2021-02-14 04:11 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Justin Pryzby @ 2021-02-14 04:11 UTC (permalink / raw) this is meant to excercize the new feature in the CIs, and not meant to be merged --- configure | 6 ++++-- configure.ac | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 0895b2f326..79e9d226ff 100755 --- a/configure +++ b/configure @@ -1571,7 +1571,7 @@ Optional Packages: --with-system-tzdata=DIR use system time zone data in DIR --without-zlib do not use Zlib - --with-lz4 build with LZ4 support + --without-lz4 build without LZ4 support --with-gnu-ld assume the C compiler uses GNU ld [default=no] --with-ssl=LIB use LIB for SSL/TLS support (openssl) --with-openssl obsolete spelling of --with-ssl=openssl @@ -8592,7 +8592,9 @@ $as_echo "#define USE_LZ4 1" >>confdefs.h esac else - with_lz4=no + with_lz4=yes + +$as_echo "#define USE_LZ4 1" >>confdefs.h fi diff --git a/configure.ac b/configure.ac index 63940b78a0..62180c5424 100644 --- a/configure.ac +++ b/configure.ac @@ -990,8 +990,8 @@ AC_SUBST(with_zlib) # LZ4 # AC_MSG_CHECKING([whether to build with LZ4 support]) -PGAC_ARG_BOOL(with, lz4, no, [build with LZ4 support], - [AC_DEFINE([USE_LZ4], 1, [Define to 1 to build with LZ4 support. (--with-lz4)])]) +PGAC_ARG_BOOL(with, lz4, yes, [build without LZ4 support], + [AC_DEFINE([USE_LZ4], 1, [Define to 1 to build without LZ4 support. (--without-lz4)])]) AC_SUBST(with_lz4) # -- 2.17.0 --m51xatjYGsM+13rf Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v24-0005-fixups.patch.patch" ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Remove some redundant set_cheapest() calls @ 2024-03-27 07:06 Richard Guo <[email protected]> 2024-03-27 14:59 ` Re: Remove some redundant set_cheapest() calls Tom Lane <[email protected]> 0 siblings, 1 reply; 3+ messages in thread From: Richard Guo @ 2024-03-27 07:06 UTC (permalink / raw) To: Tom Lane <[email protected]>; +Cc: pgsql-hackers On Wed, Mar 27, 2024 at 4:06 AM Tom Lane <[email protected]> wrote: > Richard Guo <[email protected]> writes: > > I happened to notice that the set_cheapest() calls in functions > > set_namedtuplestore_pathlist() and set_result_pathlist() are redundant, > > as we've centralized the set_cheapest() calls in set_rel_pathlist(). > > > Attached is a trivial patch to remove these calls. > > Agreed, and pushed. Thanks for pushing! > > BTW, I suspect that the set_cheapest() call in set_dummy_rel_pathlist() > > is also redundant. The comment there says "This is redundant when we're > > called from set_rel_size(), but not when called from elsewhere". I > > doubt it. The other places where it is called are set_append_rel_size() > > and set_subquery_pathlist(), both being called from set_rel_size(). So > > set_cheapest() would ultimately be called in set_rel_pathlist(). > > I'm less convinced about changing this. I'd rather keep it consistent > with mark_dummy_rel. Hm, I wonder if we should revise the comment there that states "but not when called from elsewhere", as it does not seem to be true. Thanks Richard ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Remove some redundant set_cheapest() calls 2024-03-27 07:06 Re: Remove some redundant set_cheapest() calls Richard Guo <[email protected]> @ 2024-03-27 14:59 ` Tom Lane <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Tom Lane @ 2024-03-27 14:59 UTC (permalink / raw) To: Richard Guo <[email protected]>; +Cc: pgsql-hackers Richard Guo <[email protected]> writes: > On Wed, Mar 27, 2024 at 4:06 AM Tom Lane <[email protected]> wrote: >> I'm less convinced about changing this. I'd rather keep it consistent >> with mark_dummy_rel. > Hm, I wonder if we should revise the comment there that states "but not > when called from elsewhere", as it does not seem to be true. I'd be okay with wording like "This is redundant in current usage because set_rel_pathlist will do it later, but it's cheap so we keep it for consistency with mark_dummy_rel". What do you think? regards, tom lane ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2024-03-27 14:59 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-02-14 04:11 [PATCH v24 04/10] default to --with-lz4 Justin Pryzby <[email protected]> 2024-03-27 07:06 Re: Remove some redundant set_cheapest() calls Richard Guo <[email protected]> 2024-03-27 14:59 ` Re: Remove some redundant set_cheapest() calls Tom Lane <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox