From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Nathan Bossart <nathandbossart@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Why does pgindent's README say to download typedefs.list from the buildfarm?
Date: Tue, 23 Apr 2024 10:11:45 -0400
Message-ID: <3329415.1713881505@sss.pgh.pa.us> (raw)
In-Reply-To: <202404231023.uqo3r3f5yuns@alvherre.pgsql>
References: <202404231023.uqo3r3f5yuns@alvherre.pgsql>
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> On 2024-Apr-22, Tom Lane wrote:
>> The main reason there's a delta is that people don't manage to
>> maintain the in-tree copy perfectly (at least, they certainly
>> haven't done so for this past year). So we need to do that
>> to clean up every now and then.
> Out of curiosity, I downloaded the buildfarm-generated file and
> re-indented the whole tree. It turns out that most commits seem to have
> maintained the in-tree typedefs list correctly when adding entries (even
> if out of alphabetical order), but a few haven't; and some people have
> added entries that the buildfarm script does not detect.
Yeah. I believe that happens when there is no C variable or field
anywhere that has that specific struct type. In your example,
NotificationHash appears to only be referenced in a sizeof()
call, which suggests that maybe the coding is a bit squirrely
and could be done another way.
Having said that, there already are manually-curated lists of
inclusions and exclusions hard-wired into pgindent (see around
line 70). I wouldn't have any great objection to adding more
entries there. Or if somebody wanted to do the work, they
could be pulled out into separate files.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, nathandbossart@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Why does pgindent's README say to download typedefs.list from the buildfarm?
In-Reply-To: <3329415.1713881505@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox