pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedFrom: Arthur Zakirov <a.zakirov@postgrespro.ru>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PROPOSAL] Shared Ispell dictionaries
Date: Wed, 16 Jan 2019 14:42:44 +0300
Message-ID: <337f7a55-58b8-4fcc-a933-5e7799fa6882@postgrespro.ru> (raw)
In-Reply-To: <68aaaff6-0efe-c14b-7aee-fb110bb97f69@2ndquadrant.com>
References: <20180322105603.GA23544@zakirov.localdomain>
<28250.1521924996@sss.pgh.pa.us>
<ada73d07-6c88-acab-7e31-75b2eb724d24@2ndquadrant.com>
<25186.1521951490@sss.pgh.pa.us>
<20180325205408.GA19457@arthur.localdomain>
<27296.1522078068@sss.pgh.pa.us>
<20180327121954.GA12726@zakirov.localdomain>
<CA+TgmoaR_fVd_u60mA-PHO=J1u0PmdVGOt9WaxZ1UYuGq276oQ@mail.gmail.com>
<20180516113631.GA29544@zakirov.localdomain>
<20180614084015.GA12451@zakirov.localdomain>
<20181001092204.GA5071@zakirov.localdomain>
<68aaaff6-0efe-c14b-7aee-fb110bb97f69@2ndquadrant.com>
Hello Tomas,
On 16.01.2019 03:23, Tomas Vondra wrote:
> I've looked at the patch today, and in general is seems quite solid to
> me. I do have a couple of minor points
>
> 1) I think the comments need more work. Instead of describing all the
> individual changes here, I've outlined those improvements in attached
> patches (see the attached "tweaks" patches). Some of it is formatting,
> minor rewording or larger changes. Some comments are rather redundant
> (e.g. the one before calls to release the DSM segment).
Thank you!
> 2) It's not quite clear to me why we need DictInitData, which simply
> combines DictPointerData and list of options. It seems as if the only
> point is to pass a single parameter to the init function, but is it
> worth it? Why not to get rid of DictInitData entirely and pass two
> parameters instead?
In the first place init method had two parameters. But in the v7 patch I
added DictInitData struct instead of two parameters (list of options and
DictPointerData):
https://www.postgresql.org/message-id/20180319110648.GA32319%40zakirov.localdomain
I haven't way to replace template's init method from
init_method(internal) to init_method(internal,internal) in the upgrade
script of extensions. If I'm not mistaken we need new syntax here, like
ALTER TEXT SEARCH TEMPLATE. Thoughts?
> 3) I find it a bit cumbersome that before each ts_dict_shmem_release
> call we construct a dummy DickPointerData value. Why not to pass
> individual parameters and construct the struct in the function?
Agree, it may look too verbose. I'll change it.
> 4) The reference to max_shared_dictionaries_size is obsolete, because
> there's no such limit anymore.
Yeah, I'll fix it.
> /* XXX not really a pointer, so the name is misleading */
I think we don't need DictPointerData struct anymore, because only
ts_dict_shmem_release function needs it (see comments above) and we only
need it to hash search. I'll move all fields of DictPointerData to
TsearchDictKey struct.
> XXX "supported" is not the same as "all ispell dicts behave like that".
I'll reword the sentence.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
view thread (108+ messages) latest in thread
Message-ID: <337f7a55-58b8-4fcc-a933-5e7799fa6882@postgrespro.ru>
Permalink: ../337f7a55-58b8-4fcc-a933-5e7799fa6882@postgrespro.ru/
Also on: postgresql.org/message-id/337f7a55-58b8-4fcc-a933-5e7799fa6882@postgrespro.ru
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: a.zakirov@postgrespro.ru, tomas.vondra@2ndquadrant.com, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, pavel.stehule@gmail.com, andres@anarazel.de
Subject: Re: [PROPOSAL] Shared Ispell dictionaries
In-Reply-To: <337f7a55-58b8-4fcc-a933-5e7799fa6882@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox