public inbox for [email protected]  

help / color / mirror / Atom feed

From: Nikolay Shaplov <[email protected]>
To: Alexander Korotkov <[email protected]>
To: [email protected]
Cc: Andrei Lepikhov <[email protected]>
Cc: jian he <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: [email protected]
Cc: Peter Geoghegan <[email protected]>
Cc: Finnerty, Jim <[email protected]>
Cc: Marcos Pegoraro <[email protected]>
Cc: [email protected]
Cc: Tomas Vondra <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Ranier Vilela <[email protected]>
Cc: Alena Rybakina <[email protected]>
Subject: Re: POC, WIP: OR-clause support for indexes
Date: Mon, 24 Jun 2024 23:33:29 +0300
Message-ID: <3381819.e9J7NaK4W3@thinkpad-pgpro> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CAPpHfdv087igFrMiU3yghtG9SmmYoWk0jP8WFJ9yR301CHit+w@mail.gmail.com>
	<[email protected]>

Hi!

Let me join the review process.

I am no expert in execution plans, so there would not be much help in doing 
even better optimization. But I can read the code, as a person who is not familiar 
with this area and help making it clear even to a person like me.

So, I am reading v25-0001-Transform-OR-clauses-to-ANY-expression.patch that 
have been posted some time ago, and especially transform_or_to_any function.

> @@ -38,7 +45,6 @@
>  int			from_collapse_limit;
>  int			join_collapse_limit;
>
> - 
>  /*
>   * deconstruct_jointree requires multiple passes over the join tree,  because we 
>   * need to finish computing JoinDomains before we start  distributing quals.

Do not think that removing empty line should be part of the patch

> +			/*
> +			 * If the const node's (right side of operator expression) type
> +			 * don't have “true” array type, then we cannnot do the
> +			 * transformation. We simply concatenate the expression node.
> +			 */
Guess using unicode double quotes is not the best idea here... 
   
Now to the first part of  `transform_or_to_any`


Attachments:

  [application/pgp-signature] signature.asc (488B, ../3381819.e9J7NaK4W3@thinkpad-pgpro/2-signature.asc)
  download

view thread (13+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: POC, WIP: OR-clause support for indexes
  In-Reply-To: <3381819.e9J7NaK4W3@thinkpad-pgpro>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox