From: Tom Lane <tgl@sss.pgh.pa.us>
To: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: amit.kapila16@gmail.com
Cc: robertmhaas@gmail.com
Cc: simon@2ndquadrant.com
Cc: ah@cybertec.at
Cc: pgsql-hackers@postgresql.org
Subject: Re: [HACKERS] Possibly too stringent Assert() in b-tree code
Date: Mon, 09 Jul 2018 19:29:42 -0400
Message-ID: <3390.1531178982@sss.pgh.pa.us> (raw)
In-Reply-To: <20180626.184748.29200427.horiguchi.kyotaro@lab.ntt.co.jp>
References: <18732.1474819260@sss.pgh.pa.us>
<CAA4eK1+mM8dOGcyXcW=3j4hJrJ5XOkVsMrMPJQMJFxGRj-WBew@mail.gmail.com>
<CAA4eK1K5YyDmndko0zzW6WNCN_DGFVHa6DCYcyuvkBWTH5+nUQ@mail.gmail.com>
<20180626.184748.29200427.horiguchi.kyotaro@lab.ntt.co.jp>
Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> writes:
> At Mon, 26 Sep 2016 09:12:04 +0530, Amit Kapila <amit.kapila16@gmail.com> wrote in <CAA4eK1K5YyDmndko0zzW6WNCN_DGFVHa6DCYcyuvkBWTH5+nUQ@mail.gmail.com>
>>> It seems to me that we do take actions for conflict resolution during
>>> the page deletion (that looks to be covered by XLOG_HEAP2_CLEANUP_INFO
>>> which we emit in vacuum), but not sure if that is sufficient.
>>> Consider a case where the new transaction is started on standby after
>>
>> Here by new transaction, I intend to say some newer snapshot with
>> valid MyPgXact->xmin.
> I agree to the diagnosis. So the WAL record is not necessary if
> it is a new page since no one cannot be grabbing it.
Thanks for reviving this thread and reviewing the problem.
I pushed the patch now with some more work on the comments.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, horiguchi.kyotaro@lab.ntt.co.jp, amit.kapila16@gmail.com, robertmhaas@gmail.com, simon@2ndquadrant.com, ah@cybertec.at
Subject: Re: [HACKERS] Possibly too stringent Assert() in b-tree code
In-Reply-To: <3390.1531178982@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox