pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: John Naylor <johncnaylorls@gmail.com>
Cc: Ants Aasma <ants@cybertec.at>
Cc: pgsql-hackers@postgresql.org
Subject: Re: add AVX2 support to simd.h
Date: Wed, 27 Mar 2024 17:10:13 -0400
Message-ID: <3442907.1711573813@sss.pgh.pa.us> (raw)
In-Reply-To: <20240327185716.GA4188857@nathanxps13>
References: <CANWCAZYfUv3iN2Vx--tmQP9WU6xwfU8d=gA7LoFXOYP9-wo8Hg@mail.gmail.com>
	<20240321170944.GA1767527@nathanxps13>
	<CANWCAZb7TGEk6ib12Rr6pbGMy9pqofT0dS=8Dkm+=MwJQZAEww@mail.gmail.com>
	<20240325152121.GB2662364@nathanxps13>
	<20240325213754.GA3094030@nathanxps13>
	<20240326190904.GA3700674@nathanxps13>
	<3189995.1711495704@sss.pgh.pa.us>
	<20240326235554.GA3766883@nathanxps13>
	<20240327013616.GA3940109@nathanxps13>
	<3206056.1711504137@sss.pgh.pa.us>
	<20240327185716.GA4188857@nathanxps13>

Nathan Bossart <nathandbossart@gmail.com> writes:
> Here's what I had in mind.  My usual benchmark seems to indicate that this
> shouldn't impact performance.

Shouldn't "i" be declared uint32, since nelem is?

BTW, I wonder why these functions don't declare their array
arguments like "const uint32 *base".

LGTM otherwise, and I like the fact that the #if structure
gets a lot less messy.

			regards, tom lane





view thread (48+ messages)  latest in thread

Message-ID: <3442907.1711573813@sss.pgh.pa.us>
Permalink:  ../3442907.1711573813@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3442907.1711573813@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, nathandbossart@gmail.com, johncnaylorls@gmail.com, ants@cybertec.at
  Subject: Re: add AVX2 support to simd.h
  In-Reply-To: <3442907.1711573813@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox