From: Nikolay Shaplov <dhyan@nataraj.su>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Yura Sokolov <y.sokolov@postgrespro.ru>
Cc: pgsql-hackers@lists.postgresql.org, Michael Paquier <michael@paquier.xyz>
Subject: Re: [PATCH] New [relation] option engine
Date: Fri, 08 Dec 2023 16:04:05 +0300
Message-ID: <3455090.QJadu78ljV@thinkpad-pgpro> (raw)
In-Reply-To: <202312081259.2pwkb25emowf@alvherre.pgsql>
References: <202312081259.2pwkb25emowf@alvherre.pgsql>
В письме от пятница, 8 декабря 2023 г. 15:59:09 MSK пользователь Alvaro
Herrera написал:
> > Theoretically I can create patch with full options.c as it is in the patch
> > now, and use that code only in index AM, and keep reloption.c mostly
> > unchanged.
> >
> > This will be total mess with two different options mechanisms working in
> > the same time, but this might be much more easy to review. When we are
> > done with the first step, we can change the rest.
> > If this will help to finally include patch into postgres, I can do it.
> > Will
> > that help you to review?
>
> I don't think that's better, because we could create slight
> inconsistencies between the code used for index AMs and the users of
> reloptions.
I've written quite good regression tests for it, there should be no
inconsistency.
> I'm not seeing any reasonable way to split this patch in smaller ones.
Actually me neither. Not a good one anyway.
But if somebody really need it to be split, it can be done that way.
--
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su
Attachments:
[application/pgp-signature] signature.asc (487B, ../3455090.QJadu78ljV@thinkpad-pgpro/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: dhyan@nataraj.su, alvherre@alvh.no-ip.org, y.sokolov@postgrespro.ru, michael@paquier.xyz
Subject: Re: [PATCH] New [relation] option engine
In-Reply-To: <3455090.QJadu78ljV@thinkpad-pgpro>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox