From: Tom Lane <tgl@sss.pgh.pa.us>
To: 'alvherre@alvh.no-ip.org' <alvherre@alvh.no-ip.org>
Cc: iwata.aya@fujitsu.com <iwata.aya@fujitsu.com>
Cc: tsunakawa.takay@fujitsu.com <tsunakawa.takay@fujitsu.com>
Cc: 'Kyotaro Horiguchi' <horikyota.ntt@gmail.com>
Cc: k.jamison@fujitsu.com <k.jamison@fujitsu.com>
Cc: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
Subject: Re: libpq debug log
Date: Thu, 01 Apr 2021 13:46:37 -0400
Message-ID: <3455705.1617299197@sss.pgh.pa.us> (raw)
In-Reply-To: <20210401161041.GA10892@alvherre.pgsql>
References: <20210401161041.GA10892@alvherre.pgsql>
"'alvherre@alvh.no-ip.org'" <alvherre@alvh.no-ip.org> writes:
> On 2021-Apr-01, Tom Lane wrote:
>> BTW, what in the world is this supposed to accomplish?
>> - (long long) rows_to_send);
>> + (1L << 62) + (long long) rows_to_send);
> It makes the text representation wider, which means some buffer fills up
> faster and the program switches from sending to receiving.
Hm. If the actual field value isn't relevant, why bother including
rows_to_send in it? A constant string would be simpler and much
less confusing as to its purpose.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, iwata.aya@fujitsu.com, tsunakawa.takay@fujitsu.com, horikyota.ntt@gmail.com, k.jamison@fujitsu.com, pgsql-hackers@lists.postgresql.org
Subject: Re: libpq debug log
In-Reply-To: <3455705.1617299197@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox