From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
To: pgsql-hackers@postgresql.org
Subject: Re: run pgindent on a regular basis / scripted manner
Date: Sat, 15 Aug 2020 13:47:41 +0200
Message-ID: <34b759cf-e2eb-2244-0d3b-9538b387b249@2ndquadrant.com> (raw)
In-Reply-To: <20200812223409.6di3y2qsnvynao7a@alap3.anarazel.de>
References: <20200812223409.6di3y2qsnvynao7a@alap3.anarazel.de>
On 2020-08-13 00:34, Andres Freund wrote:
> I e.g. just re-indented patch 0001 of my GetSnapshotData() series and
> most of the hunks were entirely unrelated. Despite the development
> window for 14 having only relatively recently opened. Based on my
> experience it tends to get worse over time.
Do we have a sense of why poorly-indented code gets committed? I think
some of the indentation rules are hard to follow manually. (pgperltidy
is worse.)
Also, since pgindent gets run eventually anyway, it's not really that
important to get the indentation right the first time. I suspect the
goal of most authors and committers is to write readable code rather
than to divine the exact pgindent output.
I think as a start, we could just issue a guidelines that all committed
code should follow pgindent. That has never really been a guideline, so
it's not surprising that it's not followed.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, andres@anarazel.de
Subject: Re: run pgindent on a regular basis / scripted manner
In-Reply-To: <34b759cf-e2eb-2244-0d3b-9538b387b249@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox