From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dave Cramer <davecramer@gmail.com>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_upgrade does not upgrade pg_stat_statements properly
Date: Wed, 14 Jul 2021 15:43:47 -0400
Message-ID: <3562835.1626291827@sss.pgh.pa.us> (raw)
In-Reply-To: <CADK3HHJQ=GoGcH0u2Yf2Sbes+161xMwFd4FDNGzUViH4ncbeEw@mail.gmail.com>
References: <CADK3HHKawwbOcGwMGnDuAf3-U8YfvTcS8jqDv3UM=niijs3MMA@mail.gmail.com>
<CAKFQuwY9bAJ7m0eY7aRJxF8QLZFzTJE-yO9q2Ltg8JVv=RW+wA@mail.gmail.com>
<CADK3HHL88084=-v_4ubFD4Jf2j+V8rjxLDnV1yLWn2bmVfn+Zw@mail.gmail.com>
<CAKFQuwbyfEMqsei49aBgYvQtkiskBs2TEf9mVT=k6Yijk12J0A@mail.gmail.com>
<CADK3HHJQ=GoGcH0u2Yf2Sbes+161xMwFd4FDNGzUViH4ncbeEw@mail.gmail.com>
Dave Cramer <davecramer@gmail.com> writes:
> On Wed, 14 Jul 2021 at 15:09, David G. Johnston <david.g.johnston@gmail.com>
> wrote:
>> "Install ... files used by the old cluster" (which must be binary
>> compatible with the new cluster as noted elsewhere on that page) supports
>> the claim that it is the old cluster's version that is going to result.
>> But I agree that saying "because these will be upgraded from the old
>> cluster" is poorly worded and should be fixed to be more precise here.
>>
>> Something like, "... because the installed extensions will be copied from
>> the old cluster during the upgrade."
> This is still rather opaque. Without intimate knowledge of what changes
> have occurred in each extension I have installed; how would I know what I
> have to fix after the upgrade.
That's exactly why we don't force upgrades of extensions. It is on the
user's head to upgrade their extensions from time to time, but we don't
make them do it as part of pg_upgrade. (There are also some
implementation-level reasons to avoid this, IIRC, but the overall
choice is intentional.)
I agree this documentation could be worded better. Another idea
is that possibly pg_upgrade could produce a list of extensions
that are not the latest version, so people know what's left to
be addressed.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, davecramer@gmail.com, david.g.johnston@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade does not upgrade pg_stat_statements properly
In-Reply-To: <3562835.1626291827@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox