From: David Steele <david@pgmasters.net>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: PATCH: Make pg_stop_backup() archive wait optional
Date: Mon, 27 Feb 2017 19:42:55 -0500
Message-ID: <35b7530c-68ce-7090-e13c-e39e4dac9bca@pgmasters.net> (raw)
In-Reply-To: <CAB7nPqRf6LnNN3TZZGi5DJ8sTWE5XekBSAj7E0CqsJ1nDGhiEA@mail.gmail.com>
References: <758e3fd1-45b4-5e28-75cd-e9e7f93a4c02@pgmasters.net>
<CAB7nPqRf6LnNN3TZZGi5DJ8sTWE5XekBSAj7E0CqsJ1nDGhiEA@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 2/27/17 7:38 PM, Michael Paquier wrote:
> On Tue, Feb 28, 2017 at 9:25 AM, David Steele <david@pgmasters.net> wrote:
>> I also marked the pg_stop_* functions as parallel restricted, the same
>> as pg_start_backup(). Previously they were parallel safe which I don't
>> believe is accurate for the non-exclusive version at the very least,
>> since it is tied to a particular backend.
>
> Yeah, those should really be parallel restricted. For the exclusive
> version, having the function run in parallel would also lead to errors
> per the presence/lack of backup_label file.
I'm not sure that's the case. It seems like it should lock just as
multiple backends would now. One process would succeed and the others
would error. Maybe I'm missing something?
Either way, I don't think the behavior makes any sense. Parallel safe
seems more sensible.
--
-David
david@pgmasters.net
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: david@pgmasters.net, michael.paquier@gmail.com
Subject: Re: PATCH: Make pg_stop_backup() archive wait optional
In-Reply-To: <35b7530c-68ce-7090-e13c-e39e4dac9bca@pgmasters.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox