From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Missing MaterialPath support in reparameterize_path_by_child
Date: Tue, 06 Dec 2022 09:52:51 -0500
Message-ID: <3615862.1670338371@sss.pgh.pa.us> (raw)
In-Reply-To: <CAExHW5vEiRWSyeVDCqEJMO+ok1_2RVzG7djKVPkXdGhcSq517A@mail.gmail.com>
References: <1854233.1669949723@sss.pgh.pa.us>
<CAExHW5sCvu58sthGkXRRbrgT2QZkAvaaa2mWjzEHyDZ-iahBxQ@mail.gmail.com>
<1935226.1669995790@sss.pgh.pa.us>
<CAExHW5tpV7zjY0SSDcg=5N1vddCadZ77oy-2yGQrR0zQQUFsCQ@mail.gmail.com>
<3175242.1670251415@sss.pgh.pa.us>
<CAExHW5vEiRWSyeVDCqEJMO+ok1_2RVzG7djKVPkXdGhcSq517A@mail.gmail.com>
Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> writes:
> On Mon, Dec 5, 2022 at 8:13 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I don't especially like "rel->nparts = 0" as a way of disabling
>> partitionwise join ...
> ... If we can not generate AppendPath for a
> join relation, it means there is no way to compute child join
> relations and thus the relation is not partitioned. So setting
> rel->nparts = 0 is right.
If we had nparts > 0 before, then it is partitioned for some value
of "partitioned", so I don't entirely buy this argument.
> Probably we should add macros similar to
> dummy relation for marking and checking partitioned relation. I see
> IS_PARTITIONED_RELATION() is defined already. Maybe we could add
> mark_(un)partitioned_rel().
Hiding it behind a macro with an explanatory name would be an
improvement, for sure.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, ashutosh.bapat.oss@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Missing MaterialPath support in reparameterize_path_by_child
In-Reply-To: <3615862.1670338371@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox