public inbox for [email protected]
help / color / mirror / Atom feedFrom: bt22nakamorit <[email protected]>
To: torikoshia <[email protected]>
Cc: [email protected]
Subject: Re: Make ON_ERROR_STOP stop on shell script failure
Date: Thu, 29 Sep 2022 11:29:40 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
2022-09-28 21:49 に torikoshia さんは書きました:
>> if (result == 127 || result == -1)
>> {
>> pg_log_error("\\!: failed");
>> return false;
>> }
>> else if (result != 0) {
>> pg_log_error("command failed");
>> return false;
>
> Since it would be hard to understand the cause of failures from these
> two messages, it might be better to clarify them in the messages.
>
> The former comes from failures of child process creation or execution
> on it and the latter occurs when child process creation and execution
> succeeded but the return code is not 0, doesn't it?
>
>
> I also felt it'd be natural that the latter message also begins with
> "\\!" since both message concerns with \!.
>
> How do you think?
Thank you for the feedback!
I agree that the messages should be more clear.
\\!: command was not executed
\\!: command failed
Would these two messages be enough to describe the two cases?
Tatsu
view thread (20+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Make ON_ERROR_STOP stop on shell script failure
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox