From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: Nathan Bossart <nathandbossart@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Why does pgindent's README say to download typedefs.list from the buildfarm?
Date: Wed, 24 Apr 2024 08:27:13 -0400
Message-ID: <3674465.1713961633@sss.pgh.pa.us> (raw)
In-Reply-To: <0d751dc8-0dd0-4335-a429-f43ad1e1db2f@dunslane.net>
References: <20240422192218.GB367217@nathanxps13>
<3154983.1713816488@sss.pgh.pa.us>
<20240422202010.GA420168@nathanxps13>
<3157876.1713817732@sss.pgh.pa.us>
<4dd59e83-c848-43fc-933a-5f50f6a61472@eisentraut.org>
<0d751dc8-0dd0-4335-a429-f43ad1e1db2f@dunslane.net>
Andrew Dunstan <andrew@dunslane.net> writes:
> On 2024-04-24 We 06:12, Peter Eisentraut wrote:
>> Is the code to extract typedefs available somewhere independent of the
>> buildfarm? It would be useful sometimes to be able to run this
>> locally, like before and after some patch, to keep the in-tree
>> typedefs list updated.
> There's been talk about it but I don't think anyone's done it. I'd be
> more than happy if the buildfarm client could just call something in the
> core repo (c.f. src/test/perl/Postgres/Test/AdjustUpgrade.pm).
There is already src/tools/find_typedef, which looks like it might
be an ancestral version of the current buildfarm code (which is sub
find_typedefs in run_build.pl of the client distribution). Perhaps
it'd be useful to bring that up to speed with the current BF code.
The main problem with this though is that a local run can only
give you the system-supplied typedefs for your own platform and
build options. The value-add that the buildfarm brings is to
merge the results from several different platforms.
I suppose you could set up some merging process that would add
symbols from a local run to src/tools/pgindent/typedefs.list
but never remove any. But that hardly removes the need for
an occasional cleanup pass.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andrew@dunslane.net, peter@eisentraut.org, nathandbossart@gmail.com
Subject: Re: Why does pgindent's README say to download typedefs.list from the buildfarm?
In-Reply-To: <3674465.1713961633@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox