pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Ashutosh Sharma <ashu.coek88@gmail.com>
Cc: Maciek Sakrejda <m.sakrejda@gmail.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints
Date: Thu, 04 Aug 2022 19:14:08 -0400
Message-ID: <3681809.1659654848@sss.pgh.pa.us> (raw)
In-Reply-To: <20220804225147.ypcpujdcouhmkggz@awork3.anarazel.de>
References: <CAFiTN-v4u2WJT6y1n4wtM4Z3tffJonT7zuRKegYao9p-Oyb07Q@mail.gmail.com>
	<CAFiTN-thCGvRF0_WftbDc0KFagB3vgHHGrpNdRMJ6vtkObEMoA@mail.gmail.com>
	<20220803160200.GD19644@telsasoft.com>
	<20220803170118.GG19644@telsasoft.com>
	<20220803182643.a6r2t2jyo5zxx767@awork3.anarazel.de>
	<20220803184857.GI19644@telsasoft.com>
	<CAFiTN-uCLPQf_3JHZwuMdUbMR0+tC8W5fG5-kQUKJR2b=-w-rQ@mail.gmail.com>
	<CAFiTN-v9M6myyLqZt0u5+52dqdpGkGbdjNcM3WMB5KOWcGD2tA@mail.gmail.com>
	<20220804214613.attcw2kktjz2z272@awork3.anarazel.de>
	<3664321.1659650725@sss.pgh.pa.us>
	<20220804225147.ypcpujdcouhmkggz@awork3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> On 2022-08-04 18:05:25 -0400, Tom Lane wrote:
>> In any case, DROP DATABASE is far from the only place with a problem.

> What other place has a database corrupting potential of this magnitude just
> because interrupts are accepted?  We throw valid s_b contents away and then
> accept interrupts before committing - with predictable results. We also accept
> interrupts as part of deleting the db data dir (due to catalog access).

Those things would be better handled by moving the data-discarding
steps to post-commit.  Maybe that argues for having an internal
commit halfway through DROP DATABASE: remove pg_database row,
commit, start new transaction, clean up.

			regards, tom lane





view thread (283+ messages)  latest in thread

Message-ID: <3681809.1659654848@sss.pgh.pa.us>
Permalink:  ../3681809.1659654848@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3681809.1659654848@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, dilipbalaut@gmail.com, pryzby@telsasoft.com, robertmhaas@gmail.com, ashu.coek88@gmail.com, m.sakrejda@gmail.com, bruce@momjian.us, alvherre@alvh.no-ip.org, andrew@dunslane.net, hlinnaka@iki.fi, pgsql-hackers@lists.postgresql.org
  Subject: Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints
  In-Reply-To: <3681809.1659654848@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox