pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Getting better results from valgrind leak tracking
Date: Wed, 17 Mar 2021 23:21:47 -0400
Message-ID: <3690609.1616037707@sss.pgh.pa.us> (raw)
In-Reply-To: <20210318030250.xlqxcppknzrakcs5@alap3.anarazel.de>
References: <3471359.1615937770@sss.pgh.pa.us>
	<20210317023101.anvejcfotwka6gaa@alap3.anarazel.de>
	<3479700.1615950107@sss.pgh.pa.us>
	<cea52c41-f005-4ec3-8dd8-4d12dbfbe9f6@www.fastmail.com>
	<3482163.1615953715@sss.pgh.pa.us>
	<20210318030250.xlqxcppknzrakcs5@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> The most glaring case is the RelationInitTableAccessMethod() call in
> RelationBuildLocalRelation(). Seems like the best fix is to just move
> the MemoryContextSwitchTo() to just before the
> RelationInitTableAccessMethod().  Although I wonder if we shouldn't go
> further, and move it to much earlier, somewhere after the rd_rel
> allocation.

Yeah, same thing I did locally.  Not sure if it's worth working harder.

> There's plenty other hits, but I think I should get back to working on
> making the shared memory stats patch committable. I really wouldn't want
> it to slip yet another year.

+1, so far there's little indication that we're finding any serious leaks
here.  Might be best to set it all aside till there's more time.

			regards, tom lane





view thread (23+ messages)  latest in thread

Message-ID: <3690609.1616037707@sss.pgh.pa.us>
Permalink:  ../3690609.1616037707@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3690609.1616037707@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de
  Subject: Re: Getting better results from valgrind leak tracking
  In-Reply-To: <3690609.1616037707@sss.pgh.pa.us>
  References: <3471359.1615937770@sss.pgh.pa.us> <20210317023101.anvejcfotwka6gaa@alap3.anarazel.de> <3479700.1615950107@sss.pgh.pa.us> <cea52c41-f005-4ec3-8dd8-4d12dbfbe9f6@www.fastmail.com> <3482163.1615953715@sss.pgh.pa.us> <20210318030250.xlqxcppknzrakcs5@alap3.anarazel.de> <3690609.1616037707@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox