From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Peter Eisentraut <peter_e@gmx.net>
Cc: Petr Jelinek <petr@2ndquadrant.com>
Subject: Re: 002_types.pl fails on some timezones on windows
Date: Sat, 02 Oct 2021 16:42:15 -0400
Message-ID: <3714784.1633207335@sss.pgh.pa.us> (raw)
In-Reply-To: <3266414.1633045628@sss.pgh.pa.us>
References: <20210930183641.7lh4jhvpipvromca@alap3.anarazel.de>
<f4b9c195-7caa-4849-ba67-49a5d153e203@dunslane.net>
<3204190.1633030718@sss.pgh.pa.us>
<CA+hUKG+2P0FWyPPPdCC0wFTqPeiMxFM4fCCT6r2zPYztxi5O7w@mail.gmail.com>
<3266414.1633045628@sss.pgh.pa.us>
I wrote:
> Oh, thanks for the pointer to CLDR! I tried re-generating our data
> based on theirs, and ended up with the attached draft patch.
Hearing no objections, pushed after another round of review
and a couple more fixes.
For the archives' sake, here are the remaining discrepancies
between our mapping and CLDR's entries for "territory 001",
which I take to be their recommended defaults:
* Our documented decision to map "Central America" to "CST6",
on the grounds that most of Central America doesn't actually
observe DST nowadays.
* Now-documented decision to map "Greenwich Standard Time"
to Europe/London, not Atlantic/Reykjavik as they have it.
* The miscellaneous deltas shown in the attached diff, which in
many cases boil down to "we chose the first name mentioned for the
zone, while CLDR did something else". I felt that our historical
mappings of these cases weren't wrong enough to justify any
political flak I might take for changing them. OTOH, maybe we
should just say "we follow CLDR" and be done with it.
regards, tom lane
Attachments:remaining-cldr-discrepancies.patch (text/x-diff, 2.0K) download--- findtimezone.c 2021-10-02 15:37:17.309929827 -0400+++ cldr_transformed.c 2021-10-02 14:32:32.359818338 -0400@@ -888,7 +131,7 @@ static const struct
{
/* (UTC+01:00) Belgrade, Bratislava, Budapest, Ljubljana, Prague */
"Central Europe Standard Time", "Central Europe Daylight Time",
- "Europe/Belgrade"+ "Europe/Budapest"
},
{
/* (UTC+01:00) Sarajevo, Skopje, Warsaw, Zagreb */
@@ -898,7 +141,7 @@ static const struct
{
/* (UTC+11:00) Solomon Is., New Caledonia */
"Central Pacific Standard Time", "Central Pacific Daylight Time",
- "Pacific/Noumea"+ "Pacific/Guadalcanal"
},
{
/* (UTC-06:00) Central Time (US & Canada) */
@@ -988,7 +226,7 @@ static const struct
{
/* (UTC+02:00) Helsinki, Kyiv, Riga, Sofia, Tallinn, Vilnius */
"FLE Standard Time", "FLE Daylight Time",
- "Europe/Helsinki"+ "Europe/Kiev"
},
{
/* (UTC+04:00) Tbilisi */
@@ -1006,7 +244,7 @@ static const struct
{
/* (UTC+02:00) Athens, Bucharest */
"GTB Standard Time", "GTB Daylight Time",
- "Europe/Athens"+ "Europe/Bucharest"
},
{
/* (UTC-05:00) Haiti */
@@ -1244,7 +441,7 @@ static const struct
{
/* (UTC+01:00) Brussels, Copenhagen, Madrid, Paris */
"Romance Standard Time", "Romance Daylight Time",
- "Europe/Brussels"+ "Europe/Paris"
},
{
/* (UTC+11:00) Chokurdakh */
@@ -1349,7 +491,7 @@ static const struct
{
/* (UTC+13:00) Samoa */
"Samoa Standard Time", "Samoa Daylight Time",
- "Pacific/Samoa"+ "Pacific/Apia"
},
{
/* (UTC+00:00) Sao Tome */
@@ -1519,7 +661,7 @@ static const struct
{
/* (UTC+01:00) Amsterdam, Berlin, Bern, Rome, Stockholm, Vienna */
"W. Europe Standard Time", "W. Europe Daylight Time",
- "CET"+ "Europe/Berlin"
},
{
/* (UTC+07:00) Hovd */
@@ -1533,7 +675,7 @@ static const struct
{
/* (UTC+10:00) Guam, Port Moresby */
"West Pacific Standard Time", "West Pacific Daylight Time",
- "Pacific/Guam"+ "Pacific/Port_Moresby"
},
{
/* (UTC+09:00) Yakutsk */
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, thomas.munro@gmail.com, andrew@dunslane.net, andres@anarazel.de, peter_e@gmx.net, petr@2ndquadrant.com
Subject: Re: 002_types.pl fails on some timezones on windows
In-Reply-To: <3714784.1633207335@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox