public inbox for [email protected]  
help / color / mirror / Atom feed
From: Tom Lane <[email protected]>
To: Ranier Vilela <[email protected]>
Cc: Justin Pryzby <[email protected]>
Cc: [email protected]
Subject: Re: pg17.3 PQescapeIdentifier() ignores len
Date: Thu, 13 Feb 2025 14:05:12 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAEudQAoHF228ovrBZrH0=k-=cwupRX5tvXZ31nod-H20YBTPbA@mail.gmail.com>
References: <Z64jD3u46gObCo1p@pryzbyj2023>
	<CAEudQAoHF228ovrBZrH0=k-=cwupRX5tvXZ31nod-H20YBTPbA@mail.gmail.com>

Ranier Vilela <[email protected]> writes:
> Interesting, Coverity has some new reports regarding PQescapeIdentifier.

> CID 1591290: (#1 of 1): Out-of-bounds access (OVERRUN)
> 2. alloc_strlen: Allocating insufficient memory for the terminating null of
> the string. [Note: The source code implementation of the function has been
> overridden by a builtin model.]

That's not new, we've been seeing those for awhile.  I've been
ignoring them on the grounds that (a) if the code actually had such a
problem, valgrind testing would have found it, and (b) the message is
saying in so many words that they're ignoring our code in favor of
somebody's apparently-inaccurate model of said code.

			regards, tom lane






view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pg17.3 PQescapeIdentifier() ignores len
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox