pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: typos
Date: Thu, 09 Feb 2023 01:36:48 -0500
Message-ID: <3841395.1675924608@sss.pgh.pa.us> (raw)
In-Reply-To: <Y+SIhEEVYkZf9P2f@paquier.xyz>
References: <20221230231257.GI1153@telsasoft.com>
	<Y7PZHbDrRMx5O9Hp@paquier.xyz>
	<20230103213922.GR1153@telsasoft.com>
	<20230110045722.GD9837@telsasoft.com>
	<CAA4eK1+OPcKAQneTu=2byxiRS07-NVmN0QwUFEHHw2N5osKoWw@mail.gmail.com>
	<Y70YN3RpQNBUJDeS@paquier.xyz>
	<CAA4eK1KgRPZr-2_LxAgeNCxmwnvN2nGVazoNNV1B_4SY9f=uSQ@mail.gmail.com>
	<Y75Wgpu0GLU3ArGv@paquier.xyz>
	<20230208155644.GM1653@telsasoft.com>
	<Y+SIhEEVYkZf9P2f@paquier.xyz>

Michael Paquier <michael@paquier.xyz> writes:
> On Wed, Feb 08, 2023 at 09:56:44AM -0600, Justin Pryzby wrote:
>> Some more accumulated/new typos.

> 0005 can indeed fix a lot of confusion around the spaces after an
> "else if" block.  Is that something that could be automated with the
> indentation, though?  Same remark for 0009 and 0010.

I see your point about 0005, but I've never seen pgindent remove
vertical whitespace once it's been added.  Not sure what it'd take
to teach it to do so, or whether we'd like the results.

I'd reject 0009 and 0010 altogether --- they don't add any readability
that's worth the potential increase in back-patch problems.

			regards, tom lane





view thread (54+ messages)

Message-ID: <3841395.1675924608@sss.pgh.pa.us>
Permalink:  ../3841395.1675924608@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3841395.1675924608@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, pryzby@telsasoft.com, amit.kapila16@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: typos
  In-Reply-To: <3841395.1675924608@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox