pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Subject: Re: longfin and tamandua aren't too happy but I'm not sure why
Date: Tue, 27 Sep 2022 17:50:07 -0400
Message-ID: <3845323.1664315407@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmoZk0fNrmbwAkHWy9PvnSros6cj-8qyyWe8DBhTTeRCieg@mail.gmail.com>
References: <CA+TgmoYO5ee6EWhbxz+TE9hcSDONCJvczPNv--33Uk8Xd9tMHQ@mail.gmail.com>
	<20220927200712.GH6256@telsasoft.com>
	<3825454.1664310917@sss.pgh.pa.us>
	<3837430.1664311847@sss.pgh.pa.us>
	<CA+TgmoZk0fNrmbwAkHWy9PvnSros6cj-8qyyWe8DBhTTeRCieg@mail.gmail.com>

Robert Haas <robertmhaas@gmail.com> writes:
> On Tue, Sep 27, 2022 at 4:50 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> There is a second problem that I am going to hold your feet to the
>> fire about:
>> (lldb) p sizeof(SharedInvalidationMessage)
>> (unsigned long) $1 = 24

> Also, I don't really know what problem you think it's going to cause
> if that structure gets bigger. If we increased the size from 16 bytes
> even all the way to 32 or 64 bytes, what negative impact do you think
> that would have?

Maybe it wouldn't have any great impact.  I don't know, but I don't
think it's incumbent on me to measure that.  You or the patch author
should have had a handle on that question *before* committing.

			regards, tom lane





view thread (43+ messages)  latest in thread

Message-ID: <3845323.1664315407@sss.pgh.pa.us>
Permalink:  ../3845323.1664315407@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3845323.1664315407@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, pgsql-hackers@lists.postgresql.org, pryzby@telsasoft.com, dilipbalaut@gmail.com
  Subject: Re: longfin and tamandua aren't too happy but I'm not sure why
  In-Reply-To: <3845323.1664315407@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox