pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Some regular-expression performance hacking
Date: Tue, 23 Feb 2021 12:39:09 -0500
Message-ID: <3874948.1614101949@sss.pgh.pa.us> (raw)
In-Reply-To: <20210223173437.b3ywijygsy6q42gq@alap3.anarazel.de>
References: <1340281.1613018383@sss.pgh.pa.us>
	<20210223173437.b3ywijygsy6q42gq@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> One of the recent commits have introduce a new warning with gcc 10, when
> building with optimizations:

> In file included from /home/andres/src/postgresql/src/backend/regex/regcomp.c:2304:
> /home/andres/src/postgresql/src/backend/regex/regc_nfa.c: In function ‘checkmatchall’:
> /home/andres/src/postgresql/src/backend/regex/regc_nfa.c:3087:20: warning: array subscript -1 is outside array bounds of ‘_Bool[257]’ [-Warray-bounds]
>  3087 |    hasmatch[depth] = true;
>       |                    ^

Hmph.  There's an "assert(depth >= 0)" immediately in front of that,
so I'm not looking too kindly on the compiler thinking it's smarter
than I am.  Do you have a suggestion on how to shut it up?

			regards, tom lane





view thread (38+ messages)  latest in thread

Message-ID: <3874948.1614101949@sss.pgh.pa.us>
Permalink:  ../3874948.1614101949@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3874948.1614101949@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, pgsql-hackers@lists.postgresql.org
  Subject: Re: Some regular-expression performance hacking
  In-Reply-To: <3874948.1614101949@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox