From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: adding strndup
Date: Wed, 04 Dec 2019 17:17:10 -0500
Message-ID: <3875.1575497830@sss.pgh.pa.us> (raw)
In-Reply-To: <20191204220146.GA28850@alvherre.pgsql>
References: <20191204220146.GA28850@alvherre.pgsql>
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>> I can get behind that ... it makes the patch a lot smaller.
> Here it is.
LGTM.
> I noticed that ECPG's copy was setting errno. I had forgot to do that
> in my previous patch, but on second look, malloc failure already sets
> it, so doing it again is pointless.
Right.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, andres@anarazel.de, pgsql-hackers@lists.postgresql.org
Subject: Re: adding strndup
In-Reply-To: <3875.1575497830@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox